FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.98k stars 2.29k forks source link

Bug Report: Tankman's second "Ugh" animation looks strange #2670

Open BStasik opened 5 months ago

BStasik commented 5 months ago

Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as clearing cookies, clearing AppData, trying another browser) before submitti an issueng an issue.

If you are playing the game in a browser, what site are you playing it from?

What version of the game are you using? Look in the bottom left corner of the main menu. (ex: 0.2.7, 0.2.1, shit like that)

0.4.0(still in 0.4.1)

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

No special steps/actions needed.

Please describe your issue. Provide extensive detail and images if possible.

After the second "UGH" animation, some next animations do not work until the "UGH" animation ends. It looks weird. It acts like this on any game difficulty.

Hundrec commented 5 months ago

This happens due to the way the Play Animation event works. If “Force” is checked, the animation will play through its full duration and override all other animations (Ugh, hey, cheer, etc.)

BStasik commented 5 months ago

This happens due to the way the Play Animation event works. If “Force” is checked, the animation will play through its full duration and override all other animations (Ugh, hey, cheer, etc.)

But I don't think its supposed to work like that.

Hundrec commented 5 months ago

This happens due to the way the Play Animation event works. If “Force” is checked, the animation will play through its full duration and override all other animations (Ugh, hey, cheer, etc.)

But I don't think its supposed to work like that.

It definitely shouldn’t! I think they should change the way “singing time” is coded so we can specify the number of steps we want a forced animation to play for in the Event menu.

Hundrec commented 5 months ago

Here's a video of the Ugh animation playing for 8 steps and overlapping two of Tankman's arrow animations.

https://github.com/FunkinCrew/Funkin/assets/170126004/68bf47fe-3ab0-4370-bf97-106a4684191e

BStasik commented 5 months ago

Here's a video of the Ugh animation playing for 8 steps and overlapping two of Tankman's arrow animations.

Ugh.animation.mp4

thanks! :3

NotHyper-474 commented 5 months ago

Btw someone made the https://github.com/FunkinCrew/funkin.assets/pull/5 PR to fix this issue, it never got merged tho

Hundrec commented 5 months ago

Btw someone made the FunkinCrew/funkin.assets#5 PR to fix this issue, it never got merged tho

Good to know! I suppose they might be looking for a more generally applicable fix that still allows charters to force full length animations to play.

Hundrec commented 1 month ago

This (and other forced animation bugs) still happens in 0.5.0

AbnormalPoof commented 1 month ago

Turns out this was a duplicate of #2367 this whole time.

Hundrec commented 1 month ago

Yep! That goes to show how widespread this issue is

NotHyper-474 commented 1 month ago

Btw someone made the FunkinCrew/funkin.assets#5 PR to fix this issue, it never got merged tho

Update: The PR finally got merged so expect this to be fixed in 0.5.3