FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.81k stars 2.23k forks source link

Bug Report: Girlfriend no longer plays the sad animation when you lose a large combo. #2822

Open AbnormalPoof opened 2 weeks ago

AbnormalPoof commented 2 weeks ago

Describe the bug

As of the WeekEnd 1 update, Girlfriend no longer plays the sad animation when dropping a combo. Before, if you missed a note with a combo of 10 or higher, she would cry. Now, that animation seems to not work anymore.

Screenshots/Video

Both videos are recorded on the HTML5 build of the game, but this also occurs on desktop as well.

https://github.com/FunkinCrew/Funkin/assets/86753001/564b60da-ce59-43f5-8b87-035489d15b51

https://github.com/FunkinCrew/Funkin/assets/86753001/c6e885d3-0e40-427c-90e9-536ddd3e4e4c

Desktop

Additional context

Looking in GF's json file, there's an animation set for dropping a combo of 70. Screenshot 2024-06-15 at 5 47 33 PM

(Nene also has similar entries!) Screenshot 2024-06-15 at 5 47 55 PM

In the source code, they're meant to play, but they aren't for some reason? I'm not sure why. Screenshot 2024-06-15 at 5 50 09 PM

Hundrec commented 1 week ago

Just dug through the 0.2.x branch and found this:

image

I had no idea the crying animation played with a combo of 6 or higher rather than 10.

Anyway, I'm going to attempt to reimplement the animation for combos of 70 or higher.

AbnormalPoof commented 5 days ago

I think I ironed out the issue with BaseCharacter. I noticed that the drop code was using event.comboCount. I changed that to use Highscore.tallies.combo instead and that seemed to work! I also implemented the combo### animations as well. I'll make a PR with these changes later today.