search

FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.81k stars 2.24k forks source link

Bug Report: Opponent stops singing on miss when bf has no vocals file #2837

Open IDiMooo opened 2 weeks ago

IDiMooo commented 2 weeks ago

Describe the bug

When there is only one vocal file for opponent and not for boyfriend, this audio will stop play on miss even if it's not bf's vocal file.

To Reproduce

Create a song with only one vocal file for opponent and miss a note before opponent's turn.

Expected behavior

The audio should still play if I understand why the vocals were seperated.

Screenshots/Video

image

https://github.com/FunkinCrew/Funkin/assets/163159763/60069027-27c1-4983-82a7-02741da4d09a

Desktop

Additional context

I was porting some mods and they have the old Voices files so I just wanted to give it to opponent so it won't mute and the miss sounds will be the only thing but I noticed that even if the voices are on the opponent's side they still get muted after miss. If both vocal files are there it mutes just bf's but if there is one for opponent it mutes it too. I don't know if it is intented but ye.

M7theguy commented 2 weeks ago

This is the reason why they seperated the vocals. The mod you are playing only has one file for vocals of the opponent AND Boyfriend. A fix for this might be to check how many vocal files there are and shorten the miss effect

IDiMooo commented 2 weeks ago

Yeah I get why they seperated the files it's just the fact that bf can mute opponents side in this case which i think may not be intended