search

FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.93k stars 2.28k forks source link

Bug Report: Pico's Explosion Game Over Song Doesn't Loop #2900

Open Beelijah opened 3 months ago

Beelijah commented 3 months ago

Describe the bug

When playing the song 2Hot in Weekend 1, there is a secret death song for being exploded. However, when the song loops, it abruptly ends, and then slowly fades in again.

To Reproduce

literally die to an explosion and wait till the loop

Expected behavior

For the song to not abruptly end OR After that song ends, to play the regular song (the song without the fade in)

Screenshots/Video

youtube.com/watch=you-should-see-my-other-issue

Desktop

Additional context

none

Beelijah commented 3 months ago

Whoops! Meant to put Edge as the browser! Shouldn't matter anyways, it works on any build.

Hundrec commented 3 months ago

Good catch! This should be an easy fix, so I'll take a look at the code.

Hundrec commented 3 months ago

Just took a look, and the issue is a bit more complicated than I first thought.

image ^^^ This function in 2hot's scripts handles Pico's explosion death music and animation.

image ^^^ This function seems like it should handle looping fnf_loss_sfx-suffix rather than gameOverStart-suffix

I've replicated and recorded the bug here:

https://github.com/FunkinCrew/Funkin/assets/170126004/7519dce5-667c-42da-8692-a506035424ce

Beelijah commented 3 months ago

the comment "this code is jank as hell" lol

i dont know any C, but i know my ways kinda

onComplete (function after completion) play picodeath (regular death)

one thing to note is that during the fade in if you press retry the retry sound isn't faded in either but that doesn't matter that much

Beelijah commented 3 months ago

also they need to give you a raise/pay you if you aren't already because you have been fixing issues left and right

and if you have time, i have two other issues

edit: 4 more issues

Hundrec commented 3 months ago

It's alright, I do this for fun! I don't know how to code, but I'm happy to help however I can.

Average-FNF-Modder commented 3 months ago

It's alright, I do this for fun! I don't know how to code, but I'm happy to help however I can.

No dude you are literally the Github guy at this point you literal handle so much of their stuff and do it so professionally they should pay you bro you deserve it at this point. You like an under the counter hire my guy 😭

Beelijah commented 3 months ago

^

Braite1 commented 3 months ago

I was actually going to report this, but you beat me to it lol!

Beelijah commented 2 months ago

lol