FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.97k stars 2.29k forks source link

Voices start to glitch if the other character's voice audio file ends early #2921

Open sword0115 opened 4 months ago

sword0115 commented 4 months ago

Describe the bug

When playing a custom song, if one character's voice file ends early, the other character's voice will start to glitch. the audio glitch does not happen in the chart editor

To Reproduce

Create a custom song where one character's voices audio file ends before the other's, for instance, if one character has a voice file that is only 2 minutes long, while the second character's is 2 minutes 30 seconds, the last 30 seconds of the second character's voices will be glitched

Expected behavior

Following the above example, the last 30 seconds of the second character's voices should play normally.

Desktop

Additional context

I know this can be fixed by making the audio files the same length, but FL Studio insists on cutting out any silence at the end of the song by default, I often forget to change that setting and it constantly reverts back to default so I usually have to recompile the voices of my songs

Hundrec commented 4 months ago

I've also run into this issue many times!

This should be pretty easy to fix by someone who knows their way around PlayState.hx

sword0115 commented 1 month ago

Small update to this issue, it has gotten worse in the 0.5.0 update. Now when one character's vocals end the entire game starts to get choppy, the audio and gameplay seem to slow down and "lag"

Hundrec commented 2 weeks ago

New Swing Mode bug just dropped (reproduced in 0.5.3)

https://github.com/user-attachments/assets/5544e3cd-8c8b-433a-add2-6b6ba0003f4e

https://github.com/user-attachments/assets/ad7cd39b-7d79-4a04-9e3a-a3139b5b68d1