FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.97k stars 2.29k forks source link

[OPTIMIZATION]: Console Flooding #2936

Closed JVNpixels closed 4 months ago

JVNpixels commented 4 months ago

Describe the issue

When the user is on a compiled build of the game, there are many functions that the game traces, for example, the bopper function traces the DanceLeft and DanceRight animations, and when you miss, the console traces penalty score, this usually makes my game lag and if not, other people as well, if these traces were removed then it could even possibly improve optimization. If these functions are needed to be treced I understand, but I feel like the dance animations are unnecessary to trace, same with a few other traces.

To Reproduce

Just play a song, or open the game and you can see the console flooding with major amounts of tracing. It starts lagging on low end devices (like mine) and this is most likely the problem. I also did some testing and removed some of the traces, my game ran smoother and faster.

Expected behavior

Nothing is really wrong, but just a bug/optimization report and enhancement feature.

Screenshots/Video

Console Flood (1) Console Flood (2) Freeplay 29 FPS

Desktop

Additional context

This really frustrates me when I try to play Friday Night Funkin' and I can't even run the game smoothly, and I can't really upgrade my device at the moment until for like a couple of months, and it will also make the game more optimized in general.

NotHyper-474 commented 4 months ago

Seems like they plan on doing that considering the branch bugfix/no-traces-on-release exists.

And it appears like they also removed Bopper traces internally in https://github.com/FunkinCrew/Funkin/issues/2898

JVNpixels commented 4 months ago

Alright then, this will be closed.