FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.84k stars 2.24k forks source link

Bug Report: desktop audio quality issue #2980

Open cyn0x8 opened 2 weeks ago

cyn0x8 commented 2 weeks ago

Describe the bug

the audio quality/clarity on desktop builds is noticeably worse than that of html5/web builds (at least on windows, im unable to test on mac/linux)

To Reproduce

simply play the game on desktop and web and compare the audio quality to each other

Expected behavior

game audio should sound the same as in html5 builds or a media player

Screenshots/Video

desktop:

https://github.com/FunkinCrew/Funkin/assets/58795684/d439c50c-81cb-4261-9b83-a6d4f147119c

web:

https://github.com/FunkinCrew/Funkin/assets/58795684/bd458cbe-9ef5-4037-a1cd-f207e2ccf2c4

Desktop

Hundrec commented 2 weeks ago

The difference in audio quality is due to the use of .ogg files rather than html's .mp3 files.

This might be a limitation with HaxeFlixel, so the audio quality may always be different between desktop and web.

cyn0x8 commented 2 weeks ago

The difference in audio quality is due to the use of .ogg files rather than html's .mp3 files.

This might be a limitation with HaxeFlixel, so the audio quality may always be different between desktop and web.

the audio quality in the files themselves are pretty much the same, the change only appears ingame unless you mean like how theyre decoded

also i asked around and was told this is likely lime/openfl related so maybe it can be fixed in a fork??

Hundrec commented 2 weeks ago

Whoops, I mistakenly equated file size with audio quality!

Anyway, I do hope the audio quality can be improved with some code tweaks or even an overhauled audio system.

cyn0x8 commented 2 weeks ago

Whoops, I mistakenly equated file size with audio quality!

Anyway, I do hope the audio quality can be improved with some code tweaks or even an overhauled audio system.

tbh an audio system like fmod would be pretty cool to have in fnf but i dont know if its possible

im guessing itd also fix this weird audio delay that sometimes happens (#57 #2222 #2888) or maybe even eliminate the need to resync audio in the first place

https://github.com/FunkinCrew/Funkin/assets/58795684/52c5faf7-df0c-46eb-b01a-e375d779ad8c

Hundrec commented 2 weeks ago

I love that bug, it's hilarious

The video in https://github.com/FunkinCrew/Funkin/issues/2888 is even funnier

tposejank commented 2 weeks ago

id probably say js target's audio quality is notably worse when reproducing the audio even if it sounds normal when extracted

EliteMasterEric commented 2 weeks ago

I reviewed the videos and I do not hear the issue at all.

Also note that the audio files used for the game itself are fairly low quality on both desktop and web in order to improve bandwidth and download size.

Hundrec commented 2 weeks ago

I think the difference in quality is so subtle that most listeners can't even tell the difference through most output devices

cyn0x8 commented 1 week ago

I reviewed the videos and I do not hear the issue at all.

Also note that the audio files used for the game itself are fairly low quality on both desktop and web in order to improve bandwidth and download size.

both the original mp3 and ogg audio files themselves sound fine (as in played with a media player or something) and also sound nearly the same ingame on the web build

though on desktop something weird seems to be happening ingame where all audio (mostly high treble) feels slightly muted/less crisp and the stereo not as full

it depends on which headphones/speakers/whatever you use, but on decent drivers the difference is noticeable

https://github.com/FunkinCrew/Funkin/assets/58795684/b21c94f2-ab3d-4d5b-a9ac-01d0d197aad0

another big indicator of something going on is these artifacts appearing when viewed through a spectrogram (not a bug with the spectrogram, both recordings are pcm wav)

image


I think the difference in quality is so subtle that most listeners can't even tell the difference through most output devices

thats true, but for a music game i think its pretty important to have crisp audio!! im currently working on a mod and want players to hear the music as it was meant to be listened to

Hundrec commented 1 week ago

Whoops, I mistakenly equated file size with audio quality!

Anyway, I do hope the audio quality can be improved with some code tweaks or even an overhauled audio system.

Of course this issue should be corrected! I'm a fan of high audio quality myself :)

AbnormalPoof commented 1 week ago

both the original mp3 and ogg audio files themselves sound fine (as in played with a media player or something) and also sound nearly the same ingame on the web build

though on desktop something weird seems to be happening ingame where all audio (mostly high treble) feels slightly muted/less crisp and the stereo not as full

it depends on which headphones/speakers/whatever you use, but on decent drivers the difference is noticeable

I do hear it, desktop sounds ever so slightly more muffled

tposejank commented 1 week ago

Personally I don't see it, I respect audiophiles though. My headphones are very cheap