FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.92k stars 2.26k forks source link

Bug Report: Erect Pico Stage songs have a Null Object Reference to `cutsceneTimerManager`, causing shaders to not display. #3150

Open saturn-volv opened 5 days ago

saturn-volv commented 5 days ago

Issue Checklist

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.0

Context (Provide images, videos, etc.)

Any Erect/Nightmare song on the PhillyTrain stage will have a Null Object Reference if having played the Pico Mix previously. image

A simple fix would just be to boolean before the null check?

    playPicoCutscene = !hasPlayedInGameCutscene && 
            PlayState.instance.currentStage.getBoyfriend().characterId == 'pico-playable';

    ...

    /* #343 */ if(playPicoIntro && cutsceneTimerManager != null) cutsceneTimerManager.update(event.elapsed);

Steps to reproduce (or crash logs, errors, etc.)

MetaBreeze commented 5 days ago

Happens on newgrounds too

https://github.com/user-attachments/assets/41bb4ac6-92ed-4350-8005-0c2ec9fe314c