FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.92k stars 2.26k forks source link

Enhancement: Make the instrumental selection look better #3313

Open MrMooey opened 3 days ago

MrMooey commented 3 days ago

Issue Checklist

What is your suggestion, and why should it be implemented?

I had an idea for a way to make the instrumental menu look a little nicer, because right now it's a little barebones. Basically instead of using regular text to show which instrumental you're using, you can reuse the stylized name art from the character select menu. This means that the menu will look a little nicer and you won't to make any special art for it, even for any new characters that are added.

I made a quick mockup to show what this would look like in-game coolinstchangeideaPICO coolinstchangeideaBF

It should be implemented because the menu looks a little out of place compared to how polished every other menu looks, so unless there are plans to overhaul it in the future this would be an easy way to make it look nicer without doing extra work for it

7oltan commented 3 days ago

i wish they would do something like psych engine where you press a button and it shows you a menu, instead of it just jumpscaring you. it would be alot for new players

MrMooey commented 3 days ago

i wish they would do something like psych engine where you press a button and it shows you a menu, instead of it just jumpscaring you. it would be alot for new players

Yeah I think for the full game pressing something like ctrl to open a menu would be nice. Maybe adding some modifiers and preferences could be fun and adds some replayability to songs that would usually be pretty boring for higher level players. I think this menu though can stay as it is, I imagine that opening a menu manually would be a little too slow and feel clunky. I think the solution would be just to make this toggleable in options, or making it so that pressing something like shift+enter opens this menu and plays the song but just pressing enter just plays the song as normal.

7oltan commented 3 days ago

i wish they would do something like psych engine where you press a button and it shows you a menu, instead of it just jumpscaring you. it would be alot for new players

Yeah I think for the full game pressing something like ctrl to open a menu would be nice. Maybe adding some modifiers and preferences could be fun and adds some replayability to songs that would usually be pretty boring for higher level players. I think this menu though can stay as it is, I imagine that opening a menu manually would be a little too slow and feel clunky. I think the solution would be just to make this toggleable in options, or making it so that pressing something like shift+enter opens this menu and plays the song but just pressing enter just plays the song as normal.

I don’t think it will be clunky I read the flixel repository like it’s a book and it shouldn’t normally be laggy (I say normally cuz the devs…) i might make a pr with the menu and add some stuff like resetting the song score changing the inst (already there) and maybe setting the stage??