FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.97k stars 2.29k forks source link

Bug Report: `CAN_OPEN_LINKS` isn't defined anymore (Folder opening is broken) #3340

Closed NotHyper-474 closed 1 month ago

NotHyper-474 commented 1 month ago

Issue Checklist

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.0

Context (Provide images, videos, etc.)

This is likely related to the replacement of Project.xml with project.hxp since that's where this define was originally implemented. Since this define was used by both folder and URL opening this causes a crash when clicking "Take Me There" on the chart editor's backup popup or other buttons that open a folder.

Steps to reproduce (or crash logs, errors, etc.)

Cannot open URLs on this platform.
  in funkin/util/WindowUtil.hx#52
  in funkin/ui/debug/charting/ChartEditorState.hx#3243
  in funkin/ui/debug/charting/handlers/ChartEditorDialogHandler.hx#198
  in haxe/ui/util/EventMap.hx#90
  in haxe/ui/backend/ComponentBase.hx#441
  in haxe/ui/backend/flixel/MouseHelper.hx#201
  in haxe/ui/backend/flixel/MouseHelper.hx#191
  in haxe/ui/backend/flixel/MouseHelper.hx#173
  in haxe/ui/backend/flixel/MouseHelper.hx#103
NotHyper-474 commented 1 month ago

Apparently this is also why the merch button isn't showing up anymore

EliteMasterEric commented 1 month ago

Resolved by #3342