FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.98k stars 2.29k forks source link

Bug Report: Visual issues: Mommy Mearest's hair, Darnell's down pose #3358

Open fetusdaddy opened 2 months ago

fetusdaddy commented 2 months ago

Issue Checklist

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.0

Context (Provide images, videos, etc.)

The mom (known as Mommy Mearest)'s week 4 sprite has had a visual issue for a very long time (three years!!!): her hair shading does not display correctly. image As you can see right here, the hair shading is interrupted by the head layer's hair coloring. This could be fixed by removing the face symbol's hair coloring where the shading would be. Not too much of an issue, but I'm more just surprised it's still in the game. As for the other one, Darnell's down sprite has a frame where his hoodie strings clip through his head: image Although comedic (he looks like he's vomiting out his drawstrings), it is clearly a sprite error caused by incorrect layering in the .fla, and is quite easily fixable. I'm not sure if fixes for these are planned for when the sprites presumably switch to texture atlas spritemaps (like what Blazin uses), but I believe these are issues that could be fixed very easily Also bonus issue that has already been reported: parts of tankman's icon are not filled in. Just put it in front of a colored background, you'll see what I mean.

Steps to reproduce (or crash logs, errors, etc.)

No response

anysad commented 2 months ago

How did no one see the Darnell one, good catch!

CyndaquilDAC commented 2 months ago

Speaking of the atlas switch, wheeeen is that happening? I still don't even know if blend modes and effects are properly supported now or not.

NotHyper-474 commented 2 months ago

Darnell's bug was reported in https://github.com/FunkinCrew/Funkin/issues/3122 already but never seen someone report about Mom's hair.

fetusdaddy commented 1 month ago

Speaking of the atlas switch, wheeeen is that happening? I still don't even know if blend modes and effects are properly supported now or not.

If I'm being honest I'm just presuming this. It hasn't been confirmed anywhere, but it does make sense from a logical perspective. Having the png file contain all the parts is far more efficient than containing every frame of every sprite, especially with how often symbols are re-used.

EliteMasterEric commented 1 month ago

Darnell is a duplicate of #3122 but I do NOT see the Mom hair shading issue after squinting at it for a couple minutes

AbnormalPoof commented 1 month ago

Just looked at the FLA: Screenshot 2024-09-22 at 10 02 29 PM Screenshot 2024-09-22 at 10 02 19 PM

fetusdaddy commented 1 month ago

Darnell is a duplicate of #3122 but I do NOT see the Mom hair shading issue after squinting at it for a couple minutes

The shading is obstructed by the head. The funny thing is that this is super easy to fix, to the point where you can speedrun it in 30 seconds:

https://github.com/user-attachments/assets/25dd74ba-ab63-476d-8738-393636ca469d

Same with Darnell:

https://github.com/user-attachments/assets/946c4e1c-c840-4cce-993d-d03944730d4c

I'm surprised these haven't been patched yet, honestly.

EliteMasterEric commented 1 month ago

Darnell we can get around to fixing at some point, but Mom looks weird after the change.

image

Hundrec commented 1 month ago

Mom probably looks weird because we've seen the clipped hair since her release I'm just wondering what Dave intended