Bug Report: Game audio is still audible even when volume tray is set to 0%

[Blue2359]

Issue Checklist

• [X] I have properly named the issue
• [X] I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.0

Context (Provide images, videos, etc.)

Okay, I have no clue how I even managed to notice this, lol.

I guess there's an issue with how the volume management system works in the game; when your volume slider percentage is at 0% (WITHOUT BEING MUTED), you can still slightly hear the game, this is also the same case across all other builds; (Web, Desktop... & etc).

Steps to reproduce (or crash logs, errors, etc.)

No response

[Hundrec]

Whoa, you're right!

https://github.com/user-attachments/assets/535f4f96-c695-465e-90b2-731cb8115a89

[NotHyper-474]

This is likely related to these changes to Funkin's Flixel sound tray

[Blue2359]

It's probably this change here that causes the problem.

~... Which meannssss, this is not a funkin problem, rather a flixel problem~ Edit: nvm, just noticed that this is from the FunkinCrew flixel fork actually, so it IS a funkin problem...

[Keoiki]

Make the volume scale logarithmically, that'll be good, they thought. Look who can't reach 0 volume without the mute key!

[lemz1]

it has something to do with this function:

    public function linearToLog(x:Float, minValue:Float = 0.001):Float {
        // Ensure x is between 0 and 1
        x = Math.max(0, Math.min(1, x));

        // Convert linear scale to logarithmic
        return Math.exp(Math.log(minValue) * (1 - x));
    }

since you cant take the log of 0 you are required to have some small value above 0. so i guess you are just forced into using the mute key.

or we could force it to be 0 if x is equal to 0

[Hundrec]

I'm no coder, but I'd think to just insert a conditional somewhere in there making sure that a linear volume of 0.0 sets the actual volume to 0%

(Or what you did in your PR, that looks legit)

[EliteMasterEric]

Added a fix for this in a branch that's pending merge

[Blue2359]

Didn't mean to close this issue, whoops

[Keoiki]

Still not fixed in 0.5.1.

[EliteMasterEric]

Still not fixed in 0.5.1.

I'm confused why you say it's not fixed because I literally fixed it.

[NotHyper-474]

https://github.com/user-attachments/assets/4ceeb618-4e79-43f9-a84a-6a7d7bd6467b

Can confirm it's still not fixed. Just like before, muting with 0 works, but decreasing to 0% with - does not.

[Keoiki]

Still not fixed in 0.5.1.

I'm confused why you say it's not fixed because I literally fixed it.

I'm still able to hear audio at 0% myself (even OBS volume bars show movement), remember this isn't about the Mute key. Probably the easiest way to listen for audio at 0% is in the character select screen.

or just, y'know, set your PC's volume to 100% when the game is at 0% and you'll be able to hear it more clearly.

Also the fix done in the flixel fork presumably, but I can't find any commits fixing this.

[Blue2359]

This issue is still present in v0.5.3 btw

[ninjamuffin99]

should have a fix for this internally now!
seems like my log/linear math didn't account for taking in a 0 value, so it would always do the math with a value of 0.001 or something (since log() doesn't accept a non-zero input)

for those curious on the fix, should be in our FunkinCrew/flixel dev-6.0.0-latest branch, one of the recent commits as of writing
when this issue is marked as closed, it means it should be merged internally 🙂