FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.95k stars 2.29k forks source link

Bug Report: You can spam select a song in the freeplay menu #3562

Open Hundrec opened 2 weeks ago

Hundrec commented 2 weeks ago

Issue Checklist

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.1

Description (include any images, videos, errors, or crash logs)

On songs with alternate instrumentals, you can spam the select key. Boyfriend's new character animation doesn't affect this behavior.

This one honestly makes me chuckle.

Fresh

https://github.com/user-attachments/assets/5e456ba0-91f7-4749-ad9b-b0ee92ad60af

Monster

https://github.com/user-attachments/assets/ce4cc44b-21bc-46b3-82c4-065345ccc4d7

Steps to Reproduce

  1. Enter the Freeplay menu
  2. Select a BF song that has a Pico remix
  3. Spam Enter
amyspark-ng commented 2 weeks ago

kinda working on this

AbnormalPoof commented 2 weeks ago

You can also spam the character select transition if you spam fast enough.

amyspark-ng commented 2 weeks ago

should be an easy fix https://github.com/FunkinCrew/Funkin/blob/main/source/funkin/ui/freeplay/FreeplayState.hx#L1759

should simply be replaced with

    if (accepted && !busy)
    {
      busy = true;
      grpCapsules.members[curSelected].onConfirm();
    }

but for some reason it's not working for me!!!!

same with the character select transition!

amyspark-ng commented 2 weeks ago

is even the more weird because onConfirm() will call another function that sets busy to true, so the !busy condition would work, that's so weird

amyspark-ng commented 1 week ago

for the life of me i can't seem to fix this