Enhancement: In-game vsync option

FunkinCrew / Funkin

A rhythm game made with HaxeFlixel

https://www.newgrounds.com/portal/view/770371

Other

2.98k stars 2.29k forks source link

Enhancement: In-game vsync option #3633

Open AnniIsHere opened 1 month ago

AnniIsHere commented 1 month ago

Issue Checklist

[X] I have properly named my enhancement
[ ] I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

Recently, I have noticed a lot more screen tearing issues in fnf. Since I don't have an nvidia gpu and can't enable it from those settings, an in-game vsync option would be very useful

Hundrec commented 1 month ago

This issue was suggested here: https://github.com/FunkinCrew/Funkin/issues/2562 V-Sync would be cool to have, but we can use the 0.5.1 FPS setting for now.

AnniIsHere commented 1 month ago

I don't understand, I can't avoid screen tear with it tho?

NotHyper-474 commented 1 month ago

I believe changing the FPS limit to match your monitor's refresh rate could mitigate it, but if it still doesn't work I think enabling V-Sync could be done through modding.

I'll see if that can be done.

AbnormalPoof commented 1 month ago

V-Sync is tied to compilation, there's no real way to change it mid-game.

NotHyper-474 commented 1 month ago

I see. If it's bound to compile-time it's a limitation on OpenFL/Lime so even an official in-game option is unfeasible.

biomseed commented 1 month ago

V-Sync is bad. No no no.

AbnormalPoof commented 1 month ago

Bad to you but good to other people.