Enhancement: Let sparrow/animated health icons bop

FunkinCrew / Funkin

A rhythm game made with HaxeFlixel

https://www.newgrounds.com/portal/view/770371

Other

2.97k stars 2.29k forks source link

Enhancement: Let sparrow/animated health icons bop #3725

Open trayfellow opened 3 weeks ago

trayfellow commented 3 weeks ago

Issue Checklist

[X] I have properly named my enhancement
[X] I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

It would be neat to let icons that are loaded through sprite-sheets be able to bop alongside their legacy counterparts, putting a sparrow/animated icon next to a legacy icon definitely doesn't look right

https://github.com/user-attachments/assets/16f811e4-e6c5-4014-ab67-9892c3a27cba

Poii0 commented 3 weeks ago

Eh. It looks fine to me just make an animated icon for DD then so it looks better.

Hundrec commented 3 weeks ago

Allowing animated icons to bop would greatly improve the consistency of the UI. It would feel weird for the icons to be unaffected by the camera bop.

JVNpixels commented 3 weeks ago

Offtopic, but how did you add animated icons? Also yes, I think these should be able to bop and have a configurative option for bopping or not.

trayfellow commented 3 weeks ago

Offtopic, but how did you add animated icons? Also yes, I think these should be able to bop and have a configurative option for bopping or not.

Simply make a sparrow spritesheet of your icon, the game will automatically recognize if theres a xml spritesheet existing for it You can have 7 prefixes that change how your icon's behaving (see funkin.play.components.HealthIcon.hx line 511)

Poii0 commented 3 weeks ago

Offtopic, but how did you add animated icons? Also yes, I think these should be able to bop and have a configurative option for bopping or not.

Simply make a sparrow spritesheet of your icon, the game will automatically recognize if theres a xml spritesheet existing for it You can have 7 prefixes that change how your icon's behaving (see funkin.play.components.HealthIcon.hx line 511)

This was added in a while ago too I think in 4.0 or something. It was around the time when winning icons were added too correct me if I am wrong on that.