Bug Report: Pico is unlocked immediately if you have a modded Playable Character.

[AbnormalPoof]

Issue Checklist

• [X] I have properly named my issue
• [X] I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Itch.io (Downloadable Build) - MacOS

Browser

None

Version

v0.5.2

Description (include any images, videos, errors, or crash logs)

Using this mod: PLAYABLE MADOKA - A V-SLICE MOD as an example.

Notice how I don't have a score saved for WeekEnd 1:

Yet the animation still shows on Freeplay:

Entering the substate unlocks Pico immediately, along with the modded Playable Character:

Now Pico is playable without me needing to beat WeekEnd 1:

This also confuses mods that rely on Pico's isUnlocked() variable:

Relevant code for reference:

    /**
     * Wether or not the character should be shown.
     * @param characterID The character ID we're using.
     * @return Bool
     */
    function shouldShowCharacter(characterID:String):Bool {
        if (PlayerRegistry.instance.isCharacterOwned(characterID)) {
            var ownerID:String = PlayerRegistry.instance.getCharacterOwnerId(characterID);
            var playableCharacter:PlayableCharacter = PlayerRegistry.instance.fetchEntry(ownerID);
            return playableCharacter != null && playableCharacter.isUnlocked();
        }
        return true;
    }

Steps to Reproduce

1. Install a modded Playable Character.
2. Pico is unlocked immediately.

[JustKolosaki]

I have a feeling this is due to some code in the CharacterSelectSubState since back when it was in the debug menu you could select pico, regardless if you have beaten weekend 1 or not. Selecting pico while he was still locked through the aforementioned trick caused some glitchy behaviour like no songs besides random being available until scrolling difficulties.

I'll give it a check for sure

Edit: I was right, the unlock characters function doesn't check if the character is available to be unlocked,,,,facepalm emoji,,,,,,

[AbnormalPoof]

Opened a PR which fixes this (#3748)

[Average-FNF-Modder]

Wait how do you get to that screen in the final image

[AbnormalPoof]

It's a mod

[Average-FNF-Modder]

It's a mod

Oh mb.