FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.96k stars 2.29k forks source link

Enhancement: Allow for refreshing the mod scripts currently active and stop them from being permanently loaded. #3795

Open Average-FNF-Modder opened 3 hours ago

Average-FNF-Modder commented 3 hours ago

Issue Checklist

What is your suggestion, and why should it be implemented?

      Currently, if you want to make an edit to a script, the only way to do it is to edit the script, and then entirely close and reopen the game, which can get especially annoying if you're doing a script for a chart, but every time you wanna tweak a value you have to quit the game. Imagine having to close the game every time you wanted to zoom in the camera with an event and test it. So I suggest having:

  1. A button in either the File or Edit dropdowns of chart editor that is a Refresh Song Script button, which, as the name implies, refreshes that charts script on it's own.
  2. Another button in chart editor "Refresh All Scripts" or whatnot, which fully refreshes all scripts.
  3. A button in the regular debug menu which also refreshes all scripts.

      In addition to this, scripts currently do not at all register when they have deleted. I couldn't tell if this was a bug or not, but it's very annoying. The only way to remove a scripts effects is to edit it to be blank, which I had to find out myself by floundering, as this is not intuitive at all. Removing from the folder and even straight up deleting a .hxc file does not remove it's effect on the game, I guess it somehow stays stored in the games memory until it sees an edit, and it doesn't count deleting as editing?- so I would also suggest that the game checks if a loaded script is even still there when loading in scripts.

NotHyper-474 commented 2 hours ago

Can't you just press F5 to reload the scripts?

Average-FNF-Modder commented 2 hours ago

Can't you just press F5 do reload the scripts?

That's... a thing? If it is it should really be in a hotkeys menu or explained like, somewhere right? Even still most things doable with hotkeys should also have their own buttons in a dropdown for people still learning at least, and the issue with deleted scripts staying loaded would still stand.

AbnormalPoof commented 2 hours ago

There’s a file that documents all the debug hotkeys for FNF.

Keoiki commented 1 hour ago

I read the title of this issue in my head and said "F5" aloud to myself.

Hundrec commented 1 hour ago

I think this issue is plenty resolved and can be closed now!