FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.98k stars 2.29k forks source link

Bug Report: Results Text is moveable #3845

Open JVNpixels opened 2 weeks ago

JVNpixels commented 2 weeks ago

Issue Checklist

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

v0.5.3

Description (include any images, videos, errors, or crash logs)

I was spamming arrow keys in the results screen for fun, but then I saw that the text was moving? (Hitsounds were included for proof of pressing arrow keys)

https://github.com/user-attachments/assets/55df9392-e25f-455c-a742-df63da41823d

Nothing really else to say, but I don't know if this was an intentional debug feature that was left in by mistake or something?

Steps to Reproduce

  1. Open the game...
  2. Beat a week/song through Story Mode or Freeplay
  3. Get to the results screen
  4. Press arrow keys and (maybe) see error.
JVNpixels commented 2 weeks ago

I am still able to reproduce without mods.

AbnormalPoof commented 2 weeks ago

Looks like this is some leftover debug code! https://github.com/FunkinCrew/Funkin/blob/9e13ea0b2c0799d9a7fae7db56eddb05898739d0/source/funkin/play/ResultState.hx#L724C1-L729C6

amyspark-ng commented 2 weeks ago

i've known about this for months but didn't want people to find out so they don't remove it :pensive:

AbnormalPoof commented 2 weeks ago

i've known about this for months but didn't want people to find out so they don't remove it 😔


import funkin.play.ResultState;
import funkin.modding.module.Module;
import flixel.FlxG;

class ResultsThing extends Module {
    public function new() {
        super('ResultsThing');
    }

    function onUpdate() {
        if (FlxG.state.subState is ResultState) {
          if (FlxG.keys.justPressed.RIGHT) FlxG.state.subState.speedOfTween.x += 0.1;
          if (FlxG.keys.justPressed.LEFT) FlxG.state.subState.speedOfTween.x -= 0.1;
        }
    }
}