search

FunkinCrew / Funkin

A rhythm game made with HaxeFlixel
https://www.newgrounds.com/portal/view/770371
Other
2.98k stars 2.29k forks source link

Bug Report: Vocal Resync on Inst-Only Mod songs #3856

Open sphis-Sinco opened 6 days ago

sphis-Sinco commented 6 days ago

Issue Checklist

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

When playing modded songs the game keeps registering that the vocals need resync even when the song doesn't even have vocals, this causes notes to jump or stay for longer and causes the Instrumental to keep jumping to different positions in the track.

The only way around this issue is playing the song in the Chart Editor by loading the .fnfc file because the vocals need to be there otherwise loading it from the "load from song" section crashes the game.

I have a video with this issue here

Steps to Reproduce

1) Make or download a mod with an instrumental only song 2) Play the song from Freeplay 3) Notice the instrumental cutting and jumping to different positions in the song

AbnormalPoof commented 6 days ago

Can't reproduce. I'm not sure how this bug would even occur since resyncVocals() returns if the Vocals don't exist.

sphis-Sinco commented 6 days ago

Can't reproduce. I'm not sure how this bug would even occur since resyncVocals() returns if the Vocals don't exist.

I have a video with the issue here

sphis-Sinco commented 6 days ago

Can't reproduce. I'm not sure how this bug would even occur since resyncVocals() returns if the Vocals don't exist.

Also when I run the game in terminal I see this traced in the logs

image

KoloInDaCrib commented 6 days ago

Can't reproduce. I'm not sure how this bug would even occur since resyncVocals() returns if the Vocals don't exist.

That only checks if the VoicesGroup itself is null, not whether or not the voices within it are existent or not. I'm guessing the bug happens since when you have no voices in the group itself the time doesn't update (since it doesn't have what to update lol)

Also I was able to repro this by simply removing all the voice files (there are a LOT of checks for the voice file good god eric)

sphis-Sinco commented 5 days ago

turns out this just happens to Modded songs in general

sphis-Sinco commented 5 days ago

nvm