FunkyFr3sh / cnc-ddraw

GDI, OpenGL and Direct3D 9 re-implementation of the DirectDraw API for classic 2D games for better compatibility with Windows 2000, XP, Vista, 7, 8, 10, 11, Wine (Linux/macOS/Android) and Virtual Machines
https://discord.gg/afWXJNDDF5
MIT License
2.13k stars 143 forks source link

Random graphical crap on crt-lottes.glsl #270

Closed emxd closed 6 months ago

emxd commented 7 months ago

Hello,

On crt-lottes.glsl there is this random graphical debris around the *curvature*. I tried the shader with Retroarch on Enemy Infestation and there was no such problem. I've seen this in multiple games, but it's easy to reproduce in Enemy Infestation

Screenshot (202)

Putting glClear after https://github.com/FunkyFr3sh/cnc-ddraw/blob/dc3be1243ac720827c1ce1c3dc6e7fb26eb33685/src/render_ogl.c#L577-L588

solves the issue, although maybe it should be put in a different place.

FunkyFr3sh commented 7 months ago

should be fixed now:

cnc-ddraw.zip

emxd commented 7 months ago

Sorry, this doesn't work, it remains the same.

FunkyFr3sh commented 7 months ago

Is this on windows? I remember having similar issues on linux

emxd commented 7 months ago

Windows 11 22h2

edit: demo for the game can be downloaded from https://archive.org/download/gs-299-b/GS299B.ISO/Demos%2FEnemyInf%2FENEMYINF.EXE

FunkyFr3sh commented 6 months ago

I think I got it fixed, but I can't reproduce it. This issue may be specific to only crt-lottes, it probably happens because the framebuffer is bigger than the game's resolution so the warp effect takes some junk data from outside the visible area somehow

cnc-ddraw.zip

emxd commented 6 months ago

Yes, it works correctly. Thanks.