FunkyFr3sh / cnc-ddraw

GDI, OpenGL and Direct3D 9 re-implementation of the DirectDraw API for classic 2D games for better compatibility with Windows 2000, XP, Vista, 7, 8, 10, 11, Wine (Linux/macOS/Android) and Virtual Machines
https://discord.gg/afWXJNDDF5
MIT License
2.12k stars 143 forks source link

JazzJackrabiit 2 plus: several issues #314

Closed legluondunet closed 1 month ago

legluondunet commented 1 month ago

Hello, I own JazzJackrabit 2 plus 5.12 (bonus version with network gameplay) on GOG and I encounter some issues using cnc-draw, do you think you can fix them?

FunkyFr3sh commented 1 month ago

The game got its own Alt+Enter (just like cnc-ddraw) - When you press alt+enter it will disable ddraw and conflicts with cnc-ddraw's alt+enter.

Not sure what's the best thing to do to solve the problem, how about using Alt+Backspace for the cnc-ddraw windowed toggle? Alt+enter can still be used to open the menu (probably the best to do it in windowed mode)

cnc-ddraw-JazzJackrabbit2.zip (Alt + Backspace)

Antother option would be to remove the original Alt+Enter of the game, but then it's not possible to open the menu anymore...

Anyways, let me know if you got a better idea

legluondunet commented 1 month ago

Just tested cnc-draw version you posted above, so much improvement, in such a short time !

Not sure what's the best thing to do to solve the problem, how about using Alt+Backspace for the cnc-ddraw windowed toggle? Alt+enter can still be used to open the menu (probably the best to do it in windowed mode)

Users should still have an access to this menu for special options, even if they don't often need them. Your solution is very interesting, adding a new keyboard shortcut alt+backspace. This option would be optionnal and enable/disable in ddraw.ini? On Linux, F11 is regularly used instead of alt+enter to change fullscreen/window.

legluondunet commented 1 month ago

I think I finally found something: the window is not resizable in window mode? (alt+backspace)

FunkyFr3sh commented 1 month ago

Just tested cnc-draw version you posted above, so much improvement, in such a short time !

  • stable, no freeze or crash
  • I added ratio (maintas=true) because video were stretched, I'm happy your ratio feature is adaptive, video playing in their original format 4:3 but the game still stay in 16:9 when I choose 800x450 resolution
  • I try numerous times to crash the game: Alt+Tab, Alt+Enter, alt+backspace...let it in foreground doing another task, no crash or instability.

Not sure what's the best thing to do to solve the problem, how about using Alt+Backspace for the cnc-ddraw windowed toggle? Alt+enter can still be used to open the menu (probably the best to do it in windowed mode)

Users should still have an access to this menu for special options, even if they don't often need them. Your solution is very interesting, adding a new keyboard shortcut alt+backspace. This option would be optionnal and enable/disable in ddraw.ini? On Linux, F11 is regularly used instead of alt+enter to change fullscreen/window.

It's possible to change it via the .ini yes: image

Or if you remove the two lines from the .ini then it's also possible to change it via cnc-ddraw config.exe image

I think I finally found something: the window is not resizable in window mode? (alt+backspace)

You cannot resize it on linux currently, it will only work on windows. I had to disable it because it didn't work in some distros. On linux you can only do this: [Alt] + [Page Down] = Maximize window [Alt] + [Backspace] = Switch between windowed and fullscreen mode You can choose a custom size via the ddraw.ini width/height= settings I think you can also double click the title bar too

legluondunet commented 1 month ago

You cannot resize it on linux currently

It's not very important, with your code this game is now playable in very good conditions, stable, thank you very much!

legluondunet commented 1 month ago

Just one last thing, you should add: maintas=true by default for this game, plus and nonplus, to avoid stretch videos, just my two cents ;)

FunkyFr3sh commented 1 month ago

Just one last thing, you should add: maintas=true by default for this game, plus and nonplus, to avoid stretch videos, just my two cents ;)

I always have that enabled personally for all my games! But most people hate black bars and complain, that's why I had to disable for cnc-ddraw by default 😄