search

FunkyMonkeyLabs / notification

Library which helps you to send notification (via different channels) to user.
5 stars 1 forks source link

Drop EOL PHP versions? #5

Open shadowhand opened 8 years ago

shadowhand commented 8 years ago

PHP 5.3 and 5.4 have reached their EOL and are no longer patched. Can these versions be dropped and the package updated to more modern standards?

patryksz commented 8 years ago

Is all about entry "php": ">=5.3.0" in composer.json file or you have something different in mind? If yes, I believe that it can stay because not everyone has new versions of php.

Or is there an option, that this issue can be closed by your merged PR's?

shadowhand commented 8 years ago

I am not in favor of continuing to support PHP versions that are EOL. Users can choose lock in versions of this package that support these old versions and not upgrade until newer PHP is used.

Most important to me is to be able to use newer syntax and features, which is currently blocked by supporting PHP 5.3 and 5.4.

patryksz commented 8 years ago

Ok, you are right. I believe that this is candidate to open 2.0 version.