FunkyMuse / Vigilante

🛡️ Android security (camera/microphone dots indicators) app using Hilt, Animations, Coroutines, Material, StateFlow, Jetpack (Room, ViewModel, Paging, Security, Biometrics, Start-up) based on MVVM architecture.
GNU General Public License v3.0
772 stars 64 forks source link

Camera notification doesn`t work when using additional sensors (macro and wide-angle) #64

Open lemmcode opened 3 years ago

lemmcode commented 3 years ago

Xiaomi Mi 10 Lite, Android 10, MIUI Global 12.0.3 Stable

For example:       

FunkyMuse commented 3 years ago

Oh boy, here goes Android's broken implementation again

FunkyMuse commented 3 years ago

We'd be needing more confirmation from other devices than Xiaomi, might be Xiaomi issue only

FunkyMuse commented 3 years ago

LG G5, working fine on wide and normal camera

I'll try LG V20 once it charges a bit to power up but I'd doubt anything will change since it's the same camera setup

FunkyMuse commented 3 years ago

Yup, LG V20 and LG G5 don't suffer from the same issue, we'd need more people to give us results.

lemmcode commented 3 years ago

Tested on Galaxy A50 (Android 10, One UI 2.5) - works great with all sensors. Tested on Xiaomi Mi Note 3 (Android 9, MIUI 12.0.1) - works only with front camera. Doesn't work with two rear sensors (lol)

Seems like the problem is only with Xiaomi devices D:

Btw, microphone notifications on all devices work great

AnonymousSeal commented 3 years ago

OnePlus 5 does only show, that the camera is being used, when it is in video mode. When camera or portrait mode is selected it doesn't show, that the camera is being used.

FunkyMuse commented 3 years ago

Tested on Galaxy A50 (Android 10, One UI 2.5) - works great with all sensors. Tested on Xiaomi Mi Note 3 (Android 9, MIUI 12.0.1) - works only with front camera. Doesn't work with two rear sensors (lol)

Seems like the problem is only with Xiaomi devices D:

Btw, microphone notifications on all devices work great

OnePlus 5 does only show, that the camera is being used, when it is in video mode. When camera or portrait mode is selected it doesn't show, that the camera is being used.

These problems seems like they're tied to OEMs not on the developer side.

FunkyMuse commented 3 years ago

I think i might have found a solution but apparently I don't have such device to test it, is someone willing to do so?

FunkyMuse commented 3 years ago

Moved to cameraX detector, hopefully it works with this commit fix above this comment, this is gonna be launched into the new version 1.1.0 till then the issue will be reopened, if someone can clone the code and test it, it'd be great.

scientiac commented 3 years ago

Yeah this is a real issue , while using macro as well as wide as It doesn't detect the camera

FunkyMuse commented 3 years ago

I'll release a new update later today or tomorrow, hoping the aforementioned commit has the issue fixed.

FunkyMuse commented 3 years ago

Yeah this is a real issue , while using macro as well as wide as It doesn't detect the camera

Can you check 1.1.0 and see if the issue is still there?

scientiac commented 3 years ago

Yeah the bug is still there.

FunkyMuse commented 3 years ago

After digging in the source code for CameraManager availability I think this is a bug on Google's side, I might open an issue soon if I have some way to reproduce it on a real device, it sucks that I don't have a device that contains the same problem, maybe someone cal help?

rKsanu2MMYvypWePtQWM commented 3 years ago

Pocophone F1, using the 2nd rear cam (used for depth information on portraits, but can be accessed with 3rd party apps) does not show the dot. Using the infrared camera in the front does not show the dot.

geekypanda411 commented 3 years ago

Poco M2 Pro, Using Depth camera Sensor also does not notify regarding camera use.

pokegamer5547 commented 3 years ago

I'm using Redmi note 9 pro, still having the issue on the latest update.

FunkyMuse commented 3 years ago

I'm using Redmi note 9 pro, still having the issue on the latest update.

Seems like some OEMs badly implemented the camera API :(

FunkyMuse commented 3 years ago

Or google's camera manager still lacks detection for multiple camera sensors

pokegamer5547 commented 3 years ago

Or google's camera manager still lacks detection for multiple camera sensors

I feel like it's the Google camera manager doens't detect the multiple sensors. But I maybe wrong tho I'm not an developer. But I know it's annoying and hard to fix on developer side without having real device :(

FunkyMuse commented 3 years ago

Or google's camera manager still lacks detection for multiple camera sensors

I feel like it's the Google camera manager doens't detect the multiple sensors. But I maybe wrong tho I'm not an developer. But I know it's annoying and hard to fix on developer side without having real device :(

I looked deeper into the issue, it seems that google's camera manager is to blame, either the implementation done by Google or by the OEM you bought the phone from, the best way to address this is to either open an issue on the google issue tracker or contact the OEMs that have these issues, sadly I can't go furthermore into details since I don't own such device.

If someone with those type of devices that have this issue knows about Android development or is able to try and help, I can guide them through the process.

I'm labeling the issue with help needed, in case someone does want to help

pokegamer5547 commented 3 years ago

Or google's camera manager still lacks detection for multiple camera sensors

I feel like it's the Google camera manager doens't detect the multiple sensors. But I maybe wrong tho I'm not an developer. But I know it's annoying and hard to fix on developer side without having real device :(

I looked deeper into the issue, it seems that google's camera manager is to blame, either the implementation done by Google or by the OEM you bought the phone from, the best way to address this is to either open an issue on the google issue tracker or contact the OEMs that have these issues, sadly I can't go furthermore into details since I don't own such device.

If someone with those type of devices that have this issue knows about Android development or is able to try and help, I can guide them through the process.

I'm labeling the issue with help needed, in case someone does want to help

Oh but I'm not sure how can I issue to Google issue tracker and give them all the technical details like this. And miui (my phone skin) is pretty bad in taking feedback,I once tried to report some bugs but i never got any response or fix even after year. I would like to help you but sadly I don't know much about these things :( I hope somebody will help fixing this issue.

gabsoftware commented 3 years ago

Same issue with OnePlus 9 Pro. It only detects camera usage for Panorama, Slow motion, Professional and Selfie modes. All other modes, camera usage is not detected.

rajsharma91 commented 3 years ago

I'm using Redmi note 9 pro, still having the issue on the latest update. I'm Using...

Redmi Note 9 Pro (Indian Variant) Android 11 RKQ1.200826.002 MIUI 12.0.4.0 (RJWINXM) Stable Security Patch: 01-03-2021

  1. The indicator is not visible in the rear camera of portrait mode.
  2. Macro and wide-angle mode is also not working.
FunkyMuse commented 3 years ago

Tested on Google Pixel 5 and it works, I wish I had other devices to test onto....

FunkyMuse commented 3 years ago

After getting my hands on a Redmi Note 9 Pro, it seems that these bastards can't properly implement the Camera Manager that Google provides, smh.

pokegamer5547 commented 3 years ago

After getting my hands on a Redmi Note 9 Pro, it seems that these bastards can't properly implement the Camera Manager that Google provides, smh.

Damn :( those idiots, i can't believe why they change or don't properly implement the core android functionality but i noticed it too a lot of times! Like the android 10 notiffication player for youtube to seek the video directly didn't worked at all until miui 12 for me. And also now after recent update i'm no longer able yo change the priority level for notifications making those annoying icons always stay on status bar and a lot of other things. I'm never gonna buy a xaiomi phone again after this phone software updates are gone, i hate when native android features which are meant to be in every phone gets removed, yet a normal user who wouldn't even notice it because no one knows until they use.it. ik programming is hard but breaking the stuff which are meant to be aready working on vanilla android (which every OEM uses as base) is ridiculous.

FunkyMuse commented 3 years ago

After getting my hands on a Redmi Note 9 Pro, it seems that these bastards can't properly implement the Camera Manager that Google provides, smh.

Damn :( those idiots, i can't believe why they change or don't properly implement the core android functionality but i noticed it too a lot of times! Like the android 10 notiffication player for youtube to seek the video directly didn't worked at all until miui 12 for me. And also now after recent update i'm no longer able yo change the priority level for notifications making those annoying icons always stay on status bar and a lot of other things. I'm never gonna buy a xaiomi phone again after this phone software updates are gone, i hate when native android features which are meant to be in every phone gets removed, yet a normal user who wouldn't even notice it because no one knows until they use.it. ik programming is hard but breaking the stuff which are meant to be aready working on vanilla android (which every OEM uses as base) is ridiculous.

I guess Google should enforce their rules a bit more so that we can get the same functionalities across all devices, we'll see if Google's implementation of this application work when these devices get Android 12 update, since Google implemented a similar feature when mic/camera is used directly into the OS.

Newcool1230 commented 3 years ago

Just a heads up looks like this issue is also occurring on the Samsung S20+.

Only the "Photo" button won't show the dot. Everything else (Single Take, video, pro, selfie cam, portrait, slow motion, etc.) is all working.

FunkyMuse commented 2 years ago

Update: Pixel 6 PRO, every mode works, it seems to be OEM related as expected.