search

FunnelEnvy / optimizely-cli

Faster Optimizely experiment development. Code locally and publish to Optimizely through the API.
http://www.funnelenvy.com/optimizely-cli/
Apache License 2.0
54 stars 17 forks source link

Fix host command tests #59

Closed tmaiaroto closed 9 years ago

tmaiaroto commented 9 years ago

Timeout warnings and the before() seems to have a hiccup somewhere along the way.

tmaiaroto commented 9 years ago

The child process being spawned is exiting with a code of 8. I think this happens when the port is in use (I'm currently running optcli host when running tests) or when you don't have permission to bind to the port (which we likely don't have on the CI service).

nselvidge commented 9 years ago

It looks like the issue was probably being caused by running optcli without having installed it first. I don't think it's really necessary to run it through the console so I'm modifying the test to just directly call the host command by require()ing host.js

tmaiaroto commented 9 years ago

Also verified with Codeship that we can listen on ports (though that wasn't the case here).

nselvidge commented 9 years ago

fixed with #62