search

Funwayguy / BetterQuesting

MIT License
55 stars 98 forks source link

Quests automatically completing without the prerequisite item #442

Open tivec opened 5 years ago

tivec commented 5 years ago

This is a crosspost from https://github.com/NillerMedDild/Enigmatica2Expert/issues/243

I had been playing for a bit, left the world, and came back in, and suddenly I got a lot of "quest completed" notifications. At first, the quests were showing as nether stars, but doing bq_admin default load at least loaded their icons and details. However, the quests are now marked as completed, and I can claim rewards I shouldn't have had in the first place.

The pack is using version 3.5.263, and better questing quest book 3.1.1-1.12.

DevTimur commented 5 years ago

You know... This sounds like you got Quest file changed, updated maybe? Let me try to explain how this works (As i can see it)

1) In your file "minecraft\config\betterquesting\DefaultQuests.json" you have a list of quests, each quest got PERSONAL ID NUMBER. 2) Each quest can have position in Quests Pages, and even can exist in multiple Pages at same time. 3) Some quests can EXIST but does not have PAGE, you can't find them in UI, but still they exist and can be completed. 4) Quest without REWARD or TASK will complete themselves. If they have no icon, you will see Nether star.

So that what i see happend. 1) You completed some quests 2) You changed/replaced/updated "DefaultQuests.json" 3) Your save file got IDs of completed quests match with IDs of NEW quests added, so they completed itself.

Way to fix this issue.... 1) /bq_admin reset No other options, sorry

Funwayguy commented 5 years ago

There is a GUI for managing unlisted quests (Add/Remove Quests). You don't need to delete everything.

pfmoore commented 5 years ago

I had this too. I can confirm that I did not change the quest file (at least, not in any way I am aware of).

I've tried restoring the whole betterquesting folder from backup. That temporarily fixes the issue, but then a little while later the quests start to autocomplete themselves again.

I also tried /bq_admin reset all <player>. That didn't help either - quite the opposite, it put all my quests back at incomplete (wrecking my progression) and still the quests showing as "New Quest" were there.

@Funwayguy How do I get to the Add/Remove Quests GUI, and what do I need to do there? I'm a player, not the modpack author, so I don't know how the quests are meant to be defined, or anything like that.

Funwayguy commented 5 years ago

Yea reset does exactly that, just resets progress (no idea why that was suggested).

If you aren't the modpack dev and don't know what the quests are supposed to be then the editing them may actually prove worse off. If you still want to take a crack at it then use /bq_admin edit to toggle edit mode and you'll be able see the "Edit" buttons in the GUIs. Add/Remove quests can be accessed from the quest line editor screen.

Also I'd hope that the pack updates to 266 because I have been making a few anti-corruption fixes lately and having an outdated version certainly isn't helping your cases.