search

Funwayguy / BetterQuesting

MIT License
56 stars 102 forks source link

[1.12]under certain conditions quests complete without meeting criteria #491

Open mensreaMC opened 5 years ago

mensreaMC commented 5 years ago

Just saw with screenshot proof a number of a players quests being completed without the criteria having been met. The quests were set to read a certain scoreboard value. They were also set to auto-claim. I've noticed this happening to other players as well, there seems to be a lot of corruption issues around auto-claim and desync issues with repeatable quests. I can provide you with any other details, just let me know what you need. This is with the most recent version of the pack as of today.

mensreaMC commented 5 years ago

I should also have mentioned that this is on a server.

gggg336 commented 5 years ago

Hope you don't mind, but this is kind of related to the problem and opening a new ticket is a little excessive. Thanks for understanding.

Probably shouldn't have, but I updated the mod from 3.5.271 to 276 in Modern Skyblock 3 and I have the same issue in Singleplayer, craft an item (not an item required by a quest) randomly completes an entire questline and sometimes completes all of the pack's quests. These seem to be phantom completes as nothing actually gets completed in the questbook and it can repeat complete them.

mensreaMC commented 5 years ago

Do you know if the quests that are being completed when they shouldn't have the auto-claim tag?

gggg336 commented 5 years ago

Do you know if the quests that are being completed when they shouldn't have the auto-claim tag?

Most of the quests in MSB3 are not set to auto claim. The only thing I may have modified about the questbook is the removal of some items required by quests via the affected mod's config like disabling certain items in Open Blocks or removal of radiation and radiation-related items from the Extra Planets mod. I removed the affected items from CraftTweaker scripts, but not from the questbook if that would help.

mensreaMC commented 5 years ago

So I just removed auto-claim from all my quests but quests are still completing automatically. This is happening for all quests with all types of settings. It's happening on a server. As is this makes the mod and my questbook completely unplayable. Is this really only happening to us, or is no one else reporting it?

EDIT: It's completing quests for me I shouldn't even be able to complete. It's like it's just writing all over the place with no sense to it at all. Can we get some kind of response on this? I'd like to know now if I should invest any more time into making this questbook.

Funwayguy commented 5 years ago

I've only seen a few reports of this in the last few versions but haven't been able to recreate it and the code, albeit old and buggy, doesn't seem to indicate that it could randomly bypass several checks. I'm not entirely sure what would causing it but I want to guess that there is something else constantly trying modify the database. Are you able to isolate the issue to a subset of quests on a particular version of BQ that I can test?

gggg336 commented 5 years ago

Haven't updated the mod from 276 on my personally modified version of MSB 3. The mod was updated from 271 and I loaded both versions on the same save, so it is possible that it has something to do with updating the mod on the same save. The quests that are completed have no connections to each other that have already been completed by the player. Over-arching category quests auto-completed even though the player has not done a single quest in the category. The bug also seems to try and auto-complete already completed quest that the bug has gone through before.

I haven't been playing MSB 3 lately in favour of my own modpack, so I definitely haven't tested this yet.