Funwayguy / BetterQuesting

MIT License
56 stars 101 forks source link

Suggestion: Game Pauses in single player when the Questbook opens like with some other books and guis. #649

Open SirAron111 opened 5 years ago

SirAron111 commented 5 years ago

I made a Story based Modpack and that includes allot of text for people to read. I got a lot of positive feedback about the story and the explanations in the quests description. But Also a few complains that with the hardcore play style and the growing difficulty where every second counts and the impending night time grows closer every minute, that reading it all can be painful since the Questbook has no option to pause the game when looking at a quest.

So I wanted to ask if it’s possible to ad a feature that when the quest gui opens be it via the key binding or via the add-on that adds an actual book to open the quests that the game pauses.

This feature shouldn’t be too hard to implement as many other mods that add guis and books or the like are doing it and they are way less complicated that this mod.

Of course this can only work in single player and in lan world or ins servers it won’t work but that’s normal even the minecraft in game menu pauses in single player but keeps running in lan and servers.

GZ SirAron

Funwayguy commented 5 years ago

This seems easy in theory but not so much in practice. You see, a lot of BQs GUIs have network based functionality such as the submit/detect button. This is significant because Minecraft also halts all those networking actions when the game is paused.

So if I did enable pausing, checkbox tasks break, manual item/fluid/xp submissions break, any non-auto reward claims break, and all party functionality breaks down.

I do intend to split off another section of the GUI dedicated to lore where the game can be safely isolated and paused but that won't br for another few versions.

SirAron111 commented 5 years ago

A ok good to know thx for the info. Well people have to read faster than XD

SirAron111 commented 5 years ago

Mmm maybe if clicking on the text would open a popup with the text in it that does the pausing so the normal gui and tasks stay untouched and everything stays working and only when someone wants to read he click the text field the big one above the rewards and the text pops out pausing the game I mean when someone is reading he doesn’t need the quests to work he can do that after he closes the popup again when it unpauses…. As for party settings this feature is not enabled in lan world or servers and the pausing would be ignored so it doesn’t mess up others.