search

Funwayguy / InfiniteInvo

Enlarge the vanilla Minecraft inventory infintely (or until Java runs out of memory at 2.14 billion slot!)
10 stars 10 forks source link

Upgrade/Downgrade(?)/Add/Remove armour disappears #31

Closed awilliamson closed 9 years ago

awilliamson commented 9 years ago

When upgrading from 1.0.24 -> 1.0.33 ( pre 82cc9a4605 ) when restarting the server and players joining, they would lose their MagicalCrops Zivicio armour set, all of it. It would not be in their inventory, it would be gone.

When removing 1.0.33 ( pre 82cc9a4605 ), the same occurred. When adding 1.0.33 ( @82cc9a4605 ), the same occurred.

I believe this was not caused by a client bug, as the mechanics of the armour set were not present server-side ( such as flight, step assist, fall damage, etc ).

Funwayguy commented 9 years ago

Is it only applying to this specific armor set or all armors? Either way I do believe I did make a minor change on how armor is loaded sometime between 1.0.24 and 1.0.33. Removing InfiniteInvo completely would also delete the armors because of the index at which they are offset in memory to make space for the extended inventory.

awilliamson commented 9 years ago

Haven't been able to try any other sets of armour. The upgrading/downgrading part was partially due to us requiring fixes you published today. If you wish, next fix, we'll try to have alternative armour on? Some vanilla perhaps?

Funwayguy commented 9 years ago

Just posted a new update. Let me know if the armor gets deleted this time

awilliamson commented 9 years ago

We tried it with Vanilla armour from 1.0.24 -> 1.0.25. None of the vanilla armour disappeared. I believe this is fixed now, will reopen if otherwise.