search

Funwayguy / OreExcavation

Ore Excavation issue tracker
5 stars 0 forks source link

Small code Edit needed [fix in the issue]: Ghost blocks generate when digging up certain specific ores [GT6] [1.7] #13

Closed SilearFlare closed 2 years ago

SilearFlare commented 3 years ago

Hello, I have noticed a small issue with the code that generates ghost blocks when digging up specific gregtech 6 ores. We have managed to hunt down the problem to this line in MiningAgent.class, roughly line 272:

this.player.field_70170_p.markAndNotifyBlock(snap.x, snap.y, snap.z, this.player.field_70170_p.func_72964_e(snap.x >> 4, snap.y >> 4), snap.getReplacedBlock(), snap.getCurrentBlock(), snap.flag);

The problem can be fixed by switching the

snap.y >> 4

with

snap.z >>4

I had a chat on IRC with Gregorious and Speiger and they managed to point it specifically to this line. If this could be fixed, it would be extremely appreciated.

Thank you in advance!

SilearFlare commented 3 years ago

A kind soul actually compiled the fix for me (it was actually pretty hard to edit even just a byte I'm afraid) and it does, in fact, seem to be working properly now. If you'd ever like to fix this for the general populace, I can confirm that the fix that has been recommended in the issue does seem to resolve the issue itself.

FabricTesterOnly commented 1 year ago

Hi, thanks for your information. May I ask if you can provide the compiled .jar file?

SilearFlare commented 1 year ago

Sure thing. https://files.catbox.moe/gmex66.zip

FabricTesterOnly commented 1 year ago

It works! Tysm.