search

Funwayguy / OreExcavation

Ore Excavation issue tracker
5 stars 0 forks source link

Block loss when using Tinkers tools #33

Open Jkwolf25 opened 2 years ago

Jkwolf25 commented 2 years ago

Observed behavior:

While using OreExcavation with a Tinkers tool that has less durability than the blocks to be mined, the tool breaks and the blocks recovered is equal to the amount of durability the tool had left. However, the remaining blocks to be mined are voided. For example, a tool has 32 durability left, using a vein mining function allows 64 of the bolcks to be mined. performing the function, the tool breaks (expectedly) and returns 32 blocks to the player. The remaining 32 blocks of the allowable 64 (from oreexcavate) are mined but the blocks are voided.

Expected Behavior:

When performing oreexcavate function, the number of blocks allowed to be mined should not exceed the tools durability, and return the number of mined blocks.

This was observed in 2 seperate modpacks, and the only with Tinkers tools... here is a link to the Github in Tinkers I submitted https://github.com/SlimeKnights/TinkersConstruct/issues/4641#issue-1027648055

Jkwolf25 commented 2 years ago

I apologize, I must have been mistaken. I tested this more and turns out OreExcavation isnt exhibiting this behavior.

Jkwolf25 commented 2 years ago

Nope, my bad... I tested it with a mattock... Specifically, a stone Mattock from Tinkers Exhibits the above behavior.

Jkwolf25 commented 2 years ago

Yea, further tests with the Hand axe, Broad Axe, and Mattock from Tinkers exhibits the issue behavior. it is curious that those tools would do that, and Tinkers pick axes would not.

Knight mentions how it might fix here:

https://github.com/SlimeKnights/TinkersConstruct/issues/4641#issuecomment-944638402

Perhaps OreExcavation checks for the tool type? which is why Tinkers Pickaxes wouldnt be affected, but the Mattock, Broad Axe, and Hand Axe are?