Funwayguy / RealisticItemDrops

8 stars 4 forks source link

Duplication bug when using Applied Energistics Formation Plane #12

Open Jandakast opened 6 years ago

Jandakast commented 6 years ago

When the AE2 formation plane is set to drop items in the world you can dupe any item that the formation plane attempts to drop in the world. My understanding of this is original drop event is canceled and AE2 doesn't think the items were dropped. Instead of potentially deleting items it returns the items to the system. I started looking into this because it was reported on the SevTech issue tracker. This can be reproduced with just AE2 and Realistic Item Drops.

This was already reported to AE2 and they closed the issue as they have this mechanic to prevent potentially deleting a players entire storage system. Is there a way to intercept the item drop event and report back to AE2 that the drop was successful?

https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/3458

Minecraft: 1.12.2 Forge: 2678 Applied Energistics 2: rv5-stable-11 Realistic Item Drops 1.2.11

justinrusso commented 6 years ago

This seems to be on the topic of #8

Funwayguy commented 6 years ago

I've put up a new build to fix this and maybe attempt to fix #8 again but I still am not 100% sure this isn't going to break something else. For that reason, I've made it a configurable option.

My main concern with this 'fix' is that two item entities exist at the same time. The only difference between this attempt and my last is that the original item has had its contents cleared and therefore will delete itself after one tick. Any machine that picks up this item with that same tick could run into issues if it doesn't expect empty stacks. Another concern is the overhead this adds with Minecraft now having to spawn two entities, sync, delete one, then sync again every time an entity is dropped. On a small scale this is fine but if you're working with hundreds of items on conveyors, it might start having an impact.

Jandakast commented 6 years ago

So the dupe bug is fixed. But Breaking a Storage drawer full of cobble, which I do often because I don't like making tape, locks up the game. had about 200 stacks of cobble in the drawer.

Funwayguy commented 6 years ago

Thought something like that would happen. I can't fix both at the same time. It's either clean replacement with the rare dupe issue or almost triple overhead on item spawning.

Jandakast commented 6 years ago

Any idea when an actual fix for this can be done?