Funwayguy / RealisticItemDrops

8 stars 4 forks source link

[Request] Answer is probably no, but still free to ask #15

Open StevenSeegal opened 6 years ago

StevenSeegal commented 6 years ago

We are running a quite big mod pack created by ourselves and uses your mod in it. So far everything works fine until Sponge Forge changed it's behaviour. The problem we're encountering is with the EnderIO mod. In order to craft basically every machines and items you'll need 'Grains of Infinity'. These are created by using Flint & Steel on Bedrock which has a configurable percentage change to spawn a "Grain of Infinity' via EnderIO's TickEventHandler. It did work well before but since the changes in Sponge Forge the 'Grains' are not spawning anymore and throw an error in the server console. It seems like it only affects TickEvent spawns because the BlockBreak event items just spawn as intended. After a lot of testing I've narrowed it down to your mod who's causing this issue.

All I want to ask is if you are willing to make a blacklist so we can add the 'Grains of Infinity' to the blacklist and let them spawn as a normal EntityItem so Sponge Forge is not deleting it upon creation?

Funwayguy commented 6 years ago

There's already a config to enable an alternate "dupe fix" mode. I can't really fix everything resulting from replacing items all at once (too many mods doing too many different things) so that was my workaround.

StevenSeegal commented 6 years ago

It's not a dupe bug, it's an item being blocked from spawning. This is the error Sponge gives when EnderIO tries to spawn a 'Grain of Infinity' using it's server tick handler. When I remove your mod from the server all works fine.

Funwayguy commented 6 years ago

Did you try the config anyway?

I don't do support for Sponge (I don't think many devs do) because there is no way for me to reasonably test anything with it. That "error" doesn't tell me anything about what went wrong besides something with fire at a particular location.

...but sure I might consider a blacklist for items and maybe an alternate replacement method, mostly because I can think of other pack dev purposes for it. Beyond that I can't help you fix sponge related issues.