Funwayguy / RealisticItemDrops

8 stars 4 forks source link

[1.12.2] Conflict with Goldfish mod #23

Open DWX12 opened 5 years ago

DWX12 commented 5 years ago

The Goldfish mod requires players to throw the goldfish into a large enough area of water; however, this cannot occur because of the floating items mechanic. Sure that mechanic can be turned off, but that's the main reason why I wanted to use this mod in the first place.

As it is, I cannot use this mod and the Goldfish mod without turning off the floating items. A suggestion to the solution would be to have a blacklist and whitelist in the config file that items can be added to.

Great mod and thank you for your time and effort spent on it.

moonfather1 commented 5 years ago

what my goldfish mod does is, after you toss the fish item, it checks continually (every 1s, iirc) to see whether the item entity has stopped moving. once it has stopped moving, the mod does its thing.

now i never used r.i.d. (and frankly it doesn't sound like something i'd prefer, sorry) but if it keeps the item entity moving (even a little) or replaces it (grrr), my code wont be executed ever.

if r.i.d. gets some dynamic blacklist, i would be willing to send an IMC message to apply for it, but that is, in my opinion, even more than what can be reasonably expected from the rest of us.