search

Furball-Engine / Furball.Vixie

A Multi API Renderer specifically designed to be integrated into Furball, aswell as providing good Hardware support
GNU General Public License v2.0
10 stars 2 forks source link

Interfacize WindowManager #30

Closed Beyley closed 1 year ago

Beyley commented 1 year ago

Also remove a TON of global state related to graphics backends Closes #29

Eeveelution commented 1 year ago

I also find the PR name very misleading, cuz yes it does what it says but it does so much extra stuff that isn't related to the name that I was confused why the state removal stuff was even done. Also says removal of state and then also closes an issue that isnt in any way related to state

Eeveelution commented 1 year ago

Also from looking at our project page, I don't remember ever aggreing or ever hearing about us wanting to support multiple game instances? Which I don't really feel is necessary either, I don't feel the reward of being able to do it outweighs the in this PR very clearly visible negatives. It's more copy-paste/boilerplate at the cost of not having state, and I do not support it

Beyley commented 1 year ago

Also from looking at our project page, I don't remember ever aggreing or ever hearing about us wanting to support multiple game instances? Which I don't really feel is necessary either, I don't feel the reward of being able to do it outweighs the in this PR very clearly visible negatives. It's more copy-paste/boilerplate at the cost of not having state, and I do not support it

Very early on in Vixie you had written an exception saying 'no we dont support multiple game instances yet' which i took as a goal we want to go for

Eeveelution commented 1 year ago

I didn't even mean that seriously, nor did I try to imply that's a goal for us