Furcanzo / ing-sw-2019-Buratti-Capra-Chiudinelli

0 stars 1 forks source link

UML issues #4

Closed keni7385 closed 5 years ago

keni7385 commented 5 years ago

Yesterday we discussed briefly the UML at the end of the class. I have reviewed it again. There were some inheritance problems. Have you revised them?

I'm talking about the constraints, since there are many sub-classes inheriting from Constraint that have different methods among each other. Actually the relation is with Constraint, so the static description will contain only its methods. Same for effects, weapons and square.

Please, fix ASAP

PaoloC96 commented 5 years ago

Buonasera, ci stiamo adottando a modificare l'uml per migliorarlo, grazie per la segnalazione.

Paolo Capra.

PaoloC96 commented 5 years ago

Abbiamo finito di riorganizzare l'UML del Model, aggiungendo una classe helper per sistemare i problemi di passaggio di parametri su Effect, mentre per le altri classi abbiamo creato metodi astratti per gestire le sottoclassi. Speriamo di aver sistemato.

keni7385 commented 5 years ago

Okay, it seems fine. Just a couple of points to think about:

Finally I want to remind you that there is a soft deadline for your network rationale on the 7th of May. Finish your model implementation and get some working tests, especially for the weapons, ASAP. There is not so much time.

PaoloC96 commented 5 years ago

Grazie mille per i consigli, ci metteremo a lavorarci subito sopra.