Fureimi / pe

0 stars 0 forks source link

find-genre listing all books #10

Open Fureimi opened 7 months ago

Fureimi commented 7 months ago

image.png When I set a genre as empty, and I run the command find-genre followed by inputting the blank genre, it lists all books instead, including books not of that genre and books with no genre set yet.

nus-pe-script commented 7 months ago

Team's Response

image.png helloo thanku very much for your feedback It seems that the issue occurs when an empty genre is entered, which is likely not a common user action. The system's response to an empty input does not crash or corrupt the application; it simply returns all books, which is a default behavior. The core functionality of the system – to categorize and display books by genre – is not critically impacted by this bug. Users can still successfully search for books by genre if they provide a valid input. While the behavior is not ideal, it does not significantly degrade the user experience. The system still provides the correct response when keying genres. According to the provided guidelines, problems that do not cause harm and are not the result of extreme user behaviors could be categorized with a lower severity, thank you very much!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Since a user is able to set a genre as whitespaces, a user might set a new genre as empty to represent 'no-genre' or 'not yet decided'. Afterwards, they might wish to list out all books without a genre, in their case, having an empty genre. In addition, since there is no way to list all books without a genre, they might believe this is the way to find all books without a genre. Therefore, I think this should be of medium severity, as the UG does not make it clear that find-genre (empty genre) would list all books instead, regardless of their genre.