Fureimi / pe

0 stars 0 forks source link

Seq diagram missing activation bars + activation bar never ends #12

Open Fureimi opened 7 months ago

Fureimi commented 7 months ago

image.png

There are missing activation bars for :BookMain and :Ui. In addition, activation bar of :ParserMain never ends.

soc-se-bot commented 7 months ago

Team's Response

Hi thanks for pointing these errors out!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: If a developer were to read the guide, I would intepret :User as a class rather than the actual user. This might cause issues when handling your code. in addition, because of the missing end of the activation bar for ParserMain class, a developer might think that the image was cut or you forgot to include other return values, which might cause issues when trying to debug or change your code. there are 2 times when you are using return book. one is a dotted line, which means return isn't necessary as dotted line would specify return. For the other is a solid arrow, which is incorrect. Also, BookMain class does not call the getBook method, but it is returned with a book. Because of the many errors in this diagram, I feel that the severity should at least be medium.