Fureimi / pe

0 stars 0 forks source link

User is labelled as a class, ParserMain class missing activation bar, and ParserFind activation bar too long #18

Open Fureimi opened 4 months ago

Fureimi commented 4 months ago

image.png

Under: BookFind Class Component, alternatives considered

User is labelled as a class instead of an actor. ParserMain is missing activation bar, unsure if it returns anything. ParserFind activation bar is longer than the last dotted arrow

nus-pe-script commented 4 months ago

Team's Response

Helloo, thank you for your feedback!

  1. User: we will take note of this typo error thank you for raising it! this is a duplicate of issue #2339 This kind of error does not impact the overall credibility of the diagram or impede the reader’s ability to follow the sequence of events.
  2. Missing Activation Bar: The absence of an activation bar on the 'ParserMain' class might be an oversight; however, the sequence diagram is still understandable without it, this omission is not likely to cause confusion or misinterpretation of the process flow. It does not detract from the primary purpose of the diagram, which is to convey the order and interaction of components in the system.
  3. Activation Bar Length: The length of the activation bar for 'ParserFind' extending beyond the last dotted arrow is a minor graphical discrepancy. It does not mislead the reader about the functionality or sequence of operations. The core information about the process remains clear. Based on the explanation given for handling bugs that do not hinder the reader, such as minor formatting issues and cosmetic issues, these are classified as 'VeryLow' severity unless they significantly impact the reader’s ability to understand the diagram. thank youu :)

    Items for the Tester to Verify

    :question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: 1. If a developer were to read this diagram, they would intepret :User as a class, not as the actual user. This might cause confusion to the reader and is not a cosmetic issue, as per team's suggestion with a very low severity.

  1. Agree for this point.
  2. While it may be a minor graphical discrepancy, a reader might intepret your diagram as incorrect and missing a return bar from the ParserFind class, causing issues if a developer were to handle your code