search

Fureimi / pe

0 stars 0 forks source link

genre remains after deleting #2

Open Fureimi opened 7 months ago

Fureimi commented 7 months ago

image.png Once I set a genre to a book, and I remove-genre the new genre I added, when I use the display command to display information about the book, the genre remains as the new genre which i have already deleted.

soc-pe-bot commented 7 months ago

Team's Response

Hi, thanks for bringing this up!

This is an exact duplicate of #1389 and we have marked it as such! Below is the justification for our response!

As mentioned in the user guide, the remove-genre is meant to remove specific genres from the genre list that users will choose from to set genres:

image.png

While users may choose to remove a genre from the list given that they may not wish to have it as a selection, we do not want to severely restrict the users by removing the genres that have been set to it and allow them to individually change the genres of the individual books that the has the genre set.

However, we acknowledge it is potential enhancement, where we further allow users to choose if they want to remove the genre from the books that has that genre set when they are removing the genre. Hence, we have set it to NotInScope.

Hope this clarifies!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Genre not being deleted in the text file

image.png

In the text file, the genre "bruh" in the book called "bruh" is not deleted when i removed it from the program. As such, while the list of all genres does not show bruh, the genre "bruh" is still shown for the book "bruh".

image.png

To add on, we can still search for this genre, and it will return a book that had this genre, though it is meant to be removed from the list.

[original: nus-cs2113-AY2324S2/pe-interim#1240] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi, thanks for bringing this up!

As mentioned in the user guide, the remove-genre is meant to remove specific genres from the genre list that users will choose from to set genres:

image.png

While users may choose to remove a genre from the list given that they may not wish to have it as a selection, we do not want to severely restrict the users by removing the genres that have been set to it and allow them to individually change the genres of the individual books that the has the genre set.

However, we acknowledge it is potential enhancement, where we further allow users to choose if they want to remove the genre from the books that has that genre set when they are removing the genre. Hence, we have set it to NotInScope.

Hope this clarifies!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]