search

Fureniku / crafting-station

crafting station
1 stars 4 forks source link

patch for new jei version? #7

Closed PengyTheGamer closed 2 weeks ago

PengyTheGamer commented 1 month ago

sorry, kind of new to modding

i found that the bigslot class returns false to being modifiable due to not having a valid item which causes an issue with the newer jei versions

i thought it made sense to just add a check to see if a slot has an item before transferring...

please overlook this as mentioned, im pretty new to this

Fureniku commented 2 weeks ago

Unfortunately, this isn't quite the fix.

Basically, a recent change in JEI means any slot being checked has to be "modifiable" - which means if you were looking at the slot, you could put things in or out of the slot. One of the checks for if a slot is modifiable is whether its got an item in (if there's no item, you cant take anything out, so it fails the check) - so in a lot of cases, your fix here works.

However, say you have a machine or a furnace next to your table. The code will check the output slot on that furnace, which no matter what will always fail on the "putting in" check. My test world has a crafting station next to a furnace with iron ingots in the output slot, and fails here when trying to quick craft an iron pickaxe.

You were close though! If not for this edge case it would be a good fix.

PengyTheGamer commented 2 weeks ago

ahh okay, was worth the try though and thanks for this whole fork :P