Furkanzmc / zettelkasten.nvim

A Vim Philosophy Oriented Zettelkasten Note Taking Plugin
The Unlicense
227 stars 10 forks source link

Extensions #22

Closed dncnmcdougall closed 1 year ago

dncnmcdougall commented 1 year ago

I made some extensions. I don't know if you want them, but thought I would make a pull request in case you did. Feel free to reject this if you don't like the extensions, or if you don't have time or desire to look at the changes.

Here is a summary: The public interface is much the same. I added

Obviously this apparently small public interface change required some internal shuffling. The main one being that there is a new submodule zettelkasten.id which holds the id schemes.

One significant change I am not sure about is in 'zettelkasten.set_note_id`. I see that there was provision for an error if the note already exists. But it looked like it would never happen, so I made it explicit. Having done that it means that this function does not really do what it says in the documentation.

Furkanzmc commented 1 year ago

Hi Duncan!

Thanks a lot for these changes! I think this would actually be a great use case for extending this plugin and building a new one on top. If you convert this to a plugin of your own that depends on this one, I'd be happy to link to it from the README to make it easy to discover.

If there are things that you would require from this plugin for you changes to work, I'd be happy to merge those.

dncnmcdougall commented 1 year ago

Ok, great. I think we can close this pull request then. I have created an issue to discuss the possible extensions and their design: #23 I will make a pull request specifically for that when your happy with the plans.