search

FurqanSoftware / codemirror-languageserver

Language Server integration for CodeMirror 6
BSD 3-Clause "New" or "Revised" License
183 stars 24 forks source link

[enhancement] Transport Agnostic #12

Closed marc2332 closed 2 years ago

marc2332 commented 2 years ago

Hi!

It would be awesome to make this transport-agnostic instead of going fully with the WebSockets transport. I personally would like to use the EventEmitterTransport for a project of mine.

What are your thoughts? I can try to contribute 😄

hjr265 commented 2 years ago

Hey @marc2332, sorry for the delay in getting back to you.

I started the library as a part of my project and WebSocket was the only requirement there. But I can see how making this transport-agnostic can be useful.

I am happy to make this a part of the project if you send a PR.

marc2332 commented 2 years ago

Awesome! I have been digging into it for a few days, and I am very close to getting it to work with the EventEmitter transport in my project. I will try to make a PR when I get my thing working :))