Wrong types - Githubissues

FurqanSoftware / codemirror-languageserver

Language Server integration for CodeMirror 6

BSD 3-Clause "New" or "Revised" License

183 stars 24 forks source link

Open marc2332 opened 2 years ago

marc2332 commented 2 years ago

I just realized some of the TypeScript types I implemented in the last PR are not accurate at all:

LanguageServerClientOptions requires a documentUri, which is not necessary for the client
And languageServerWithTransport doesn't actually always need a transport if client is passed

I will fix this asap

hjr265 commented 2 years ago

@marc2332 Thank you for revisiting this. Sure, a PR would be appreciated.