Open marc2332 opened 2 years ago
@marc2332 Can we do this without removing languageServerWithTransport
. The improvements suggested here are great. I just also want to make sure that the update won't require the users of this library to have to then "fix" their code.
We can mark languageServerWithTransport
as deprecated, and then remove it eventually after a while.
How does that sound to you?
P.S: Sorry for taking so much time to get back to you.
Hey, I am playing with some changes to the API that would fix https://github.com/FurqanSoftware/codemirror-languageserver/issues/14 and make it slightly better.
languageServerWithTransport
tolanguageServerWithClient
, and instead of accepting a transport, directly accept a client.client
property fromlanguageServer
options, so if the dev wants to pass a client, he can uselanguageServerWithClient
.Examples:
WebSockets transport
Re using the same client
Custom transport
Thoughts?