FurqanSoftware / node-whois

A simple WHOIS client for NodeJS
https://npmjs.org/package/whois
Other
254 stars 78 forks source link

Not getting all data such as Registrant/Admin/Tech Contact by setting verbose to true. #50

Open bluerid opened 7 years ago

bluerid commented 7 years ago

I am trying to fetch all whois data associated with a domain.

whois.lookup('google.com', { "verbose": true }, function(err, data){
       if (err) throw err;
          console.log(data);
          console.log('-------------');
});

Even if I set verbose to true, the request is returning the minimal set of data. Here is the response for google.com.

[ { server: 
     { host: 'whois.verisign-grs.com',
       query: 'DOMAIN $addr\r\n',
       port: 43 },
    data: '   Domain Name: GOOGLE.COM\r\n   Registry Domain ID: 2138514_DOMAIN_COM-VRSN\r\n   Registrar WHOIS Server: whois.markmonitor.com\r\n   Registrar URL: http://www.markmonitor.com\r\n   Updated Date: 2011-07-20T16:55:31Z\r\n   Creation Date: 1997-09-15T04:00:00Z\r\n   Registry Expiry Date: 2020-09-14T04:00:00Z\r\n   Registrar: MarkMonitor Inc.\r\n   Registrar IANA ID: 292\r\n   Registrar Abuse Contact Email: abusecomplaints@markmonitor.com\r\n   Registrar Abuse Contact Phone: +1.2083895740\r\n   Domain Status: clientDeleteProhibited https://icann.org/epp#clientDeleteProhibited\r\n   Domain Status: clientTransferProhibited https://icann.org/epp#clientTransferProhibited\r\n   Domain Status: clientUpdateProhibited https://icann.org/epp#clientUpdateProhibited\r\n   Domain Status: serverDeleteProhibited https://icann.org/epp#serverDeleteProhibited\r\n   Domain Status: serverTransferProhibited https://icann.org/epp#serverTransferProhibited\r\n   Domain Status: serverUpdateProhibited https://icann.org/epp#serverUpdateProhibited\r\n   Name Server: NS1.GOOGLE.COM\r\n   Name Server: NS2.GOOGLE.COM\r\n   Name Server: NS3.GOOGLE.COM\r\n   Name Server: NS4.GOOGLE.COM\r\n   DNSSEC: unsigned\r\n   URL of the ICANN Whois Inaccuracy Complaint Form: https://www.icann.org/wicf/\r\n>>> Last update of whois database: 2017-09-07T10:01:56Z <<<\r\n\r\nFor more information on Whois status codes, please visit https://icann.org/epp\r\n\r\nNOTICE: The expiration date displayed in this record is the date the\r\nregistrar\'s sponsorship of the domain name registration in the registry is\r\ncurrently set to expire. This date does not necessarily reflect the expiration\r\ndate of the domain name registrant\'s agreement with the sponsoring\r\nregistrar.  Users may consult the sponsoring registrar\'s Whois database to\r\nview the registrar\'s reported date of expiration for this registration.\r\n\r\nTERMS OF USE: You are not authorized to access or query our Whois\r\ndatabase through the use of electronic processes that are high-volume and\r\nautomated except as reasonably necessary to register domain names or\r\nmodify existing registrations; the Data in VeriSign Global Registry\r\nServices\' ("VeriSign") Whois database is provided by VeriSign for\r\ninformation purposes only, and to assist persons in obtaining information\r\nabout or related to a domain name registration record. VeriSign does not\r\nguarantee its accuracy. By submitting a Whois query, you agree to abide\r\nby the following terms of use: You agree that you may use this Data only\r\nfor lawful purposes and that under no circumstances will you use this Data\r\nto: (1) allow, enable, or otherwise support the transmission of mass\r\nunsolicited, commercial advertising or solicitations via e-mail, telephone,\r\nor facsimile; or (2) enable high volume, automated, electronic processes\r\nthat apply to VeriSign (or its computer systems). The compilation,\r\nrepackaging, dissemination or other use of this Data is expressly\r\nprohibited without the prior written consent of VeriSign. You agree not to\r\nuse electronic processes that are automated and high-volume to access or\r\nquery the Whois database except as reasonably necessary to register\r\ndomain names or modify existing registrations. VeriSign reserves the right\r\nto restrict your access to the Whois database in its sole discretion to ensure\r\noperational stability.  VeriSign may restrict or terminate your access to the\r\nWhois database for failure to abide by these terms of use. VeriSign\r\nreserves the right to modify these terms at any time.\r\n\r\nThe Registry database contains ONLY .COM, .NET, .EDU domains and\r\nRegistrars.\r\n' } ]

I want data for administrative/technical/registrant contact. I believe this module is able to return as I see it in the readme.

spitfyr86 commented 7 years ago

Hi, @bluerid!

I also encountered this issue. So what happened is it wasn't able to resolve the whois registrar server that it suppose to redirect the query to. I just fixed the regular expression in the package. See below.

From: /(ReferralServer|Registrar Whois|Whois Server|WHOIS Server):[^\S\n](r?whois:\/\/)?(.?)/ To: /(ReferralServer|Registrar Whois|Whois Server|WHOIS Server):[^\S\n](r?whois:\/\/)?(.)/ Just remove the last question mark.

Not sure if this is the correct fix. The authors need to check on this. I could send a PR for this fix tomorrow.

StanScates commented 7 years ago

+1 for this, @hjr265 do you want us to open a PR?

spitfyr86 commented 7 years ago

@StanScates, yes please! Can you give me permission?

hjr265 commented 7 years ago

@StanScates @spitfyr86 Thank you! A PR would be really appreciated.