FuryFight3r / ScrappingSimulator

A Repository for DefectGamings Scrapping Simulator
4 stars 0 forks source link

[Bug]: 8GB DDR4 Laptop RAM stick says DDR3 after you pick it up #137

Closed the1within0 closed 1 year ago

the1within0 commented 1 year ago

Describe the bug

This appears to be a text error. The components of the RAM are indeed different, it just says DDR3 instead of DDR4

Item Waste Iron Aluminum Copper Silver Gold
8GB DDR3 Laptop RAM Stick 74.10 6.09 7.56 40.43 1.89 2.52
8GB DDR4 Laptop RAM Stick 68.40 7.35 8.82 46.73 2.52 3.15

Reproduction Steps

  1. Find a laptop with 8GB DDR4 Laptop RAM in it
  2. Remove the RAM
  3. Look in the Parts bin and it says "8GB DDR3 Laptop RAM Stick" now.

Expected behaviour

The text should still read "8GB DDR4 Laptop RAM Stick"

Also, the 8GB sticks have 12 x 512MB chips, which is only 6GB, and I would expect the numbers to add up to 8GB

Screenshot(s)/Video(s)

image image

Console output

8gbddr3_L(Clone) Is checked as 'hasDeconAnim', but a Animator Component was not found! 8gbddr4_L(Clone) Is checked as 'hasDeconAnim', but a Animator Component was not found!

Player Logs

No response

FuryFight3r commented 1 year ago

Hi there @the1within0 and thank you for reporting this issue, I will have this patched asap 🙂👍

the1within0 commented 1 year ago

Another case for the Server: image becomes image

FuryFight3r commented 1 year ago

Hi there @the1within0, and thank you for the update, yeah something is certainly wrong there, I believe v0.34 I had done a bit of reworking to the Sub E-Waste spawning system, and it seems like the ID being provided when the item is being removed is 1 less than the actual ID of the specific RAM, thus causing it to spawn the lesser/smaller RAM below the removed one or atleast some discrepancy between the IDs , hopefully can have this patched asap 🙂👍

FuryFight3r commented 1 year ago

Hi there @the1within0

Thank you for reporting this, this issue should now be fixed in the v0.35.1 Update 🙂👍