FuryFight3r / ScrappingSimulator

A Repository for DefectGamings Scrapping Simulator
4 stars 0 forks source link

[Bug]: Ingot Rack Disapears #156

Closed Tiberius-Ryx-Tyr closed 3 months ago

Tiberius-Ryx-Tyr commented 3 months ago

Describe the bug

I don't know when but my Ingot rack disappeared, and it reappeared when I bought a Ingot mold in the shop, must have refreshed something. I checked the store and it said I had the rack, tried buying it again

Reproduction Steps

Unknown. Maybe it was caused by my Ingot carry box being too close to the rack I don't know

Expected behaviour

To not disappear randomly

Screenshot(s)/Video(s)

20240328163359_1

Console output

Unknown

Player Logs

Unknown

FuryFight3r commented 3 months ago

Hi there @Tiberius-Ryx-Tyr Thank you for reporting this, that is quite an odd one, I don't imagine it would have anything to do with the Ingot Box positioning, nevertheless I will look into this 🙂👍

Tiberius-Ryx-Tyr commented 3 months ago

Oh, Save and Reload didn't manage to make it re-appear at all

FuryFight3r commented 3 months ago

That is quite odd, as reloading should certainly correct most issues as per the way I have setup the buyable objects 🤔

I may need a bit more info on this to help me in diagnosing the issue at hand, when in-game you can press [F8] to create a partial in-game Bug Report, following the steps will Pack your Save File and Player Logs for me to look into and aid with testing/fixing, it will create a secondary Bug Report on GitHub, but that's fine I may be able to merge it into this report if possible 👍

Tiberius-Ryx-Tyr commented 3 months ago

I'll keep that in mind for next time

FuryFight3r commented 3 months ago

That's fine, though I may still need the Log/Save files to fix this specific issue if you wanted the issue fixed, but if the issue is already resolved itself or you'd prefer to start a new game to fix the issue then there would be no need to send the files 👍🙂

EDIT: I only say this as testing on my end the Shelf seems to work as expected, it Saves/Loads and stores Ingots all fine it seems. With hundreds of wasted hours chasing Phantom/Save Specific Bugs in the past, atleast with your Save File/Logs I can experience the exact bug you are experiencing, without trying to guess my way there, it just helps me in helping you 🙂

Tiberius-Ryx-Tyr commented 3 months ago

Where are the In-game generated reports located?

FuryFight3r commented 3 months ago

When you click the 'Generate Zip File' button within the In-Game bug report feature it should automatically open the directory for you, it should be the only Zip file there 🙂👍

Tiberius-Ryx-Tyr commented 3 months ago

Oh It seems to happen whenever I have the Ingot Carry box right next to it Save and Restart. I think its the Hide_Shelf command getting set to true on game start, I can get it to re-appear by setting it to false.

Tiberius-Ryx-Tyr commented 3 months ago

When you click the 'Generate Zip File' button within the In-Game bug report feature it should automatically open the directory for you, it should be the only Zip file there 🙂👍

Huh it doesn't open anything for me.

Tiberius-Ryx-Tyr commented 3 months ago

Oh It seems to happen whenever I have the Ingot Carry box right next to it Save and Restart. I think its the Hide_Shelf command getting set to true on game start, I can get it to re-appear by setting it to false.

Doesn't seem to be this i removed any items close to it, it disappears every time I restart and reload without any items near it

Tiberius-Ryx-Tyr commented 3 months ago

20240328193130_1 20240328193218_1

FuryFight3r commented 3 months ago

That's incredibly strange, as the only possible way to turn the shelf off is by the user manually typing the 'hide_shelf=true' command or the only other possible reason (intentionally anyway, anything is possible when it comes to bugs 😅) the shelf won't turn back on when loading is if it thinks you don't own it, which leads me to believe it's a save file issue. At this stage there is no code that calculates the Ingot Boxes distance and turns the shelf on/off based on that distance so it's very odd that it seems to make a difference for you, also the game won't automatically run any user commands, they are there for the user to manually enter if they encounter some known issues that may still be present.

I have a suspicion that somehow your save file hasn't Ticked Off on the 'Has Placed Shelf' checkbox when the Ingot Shelf Box was placed, which would lead to the shelf not being active upon loading. So not only would I need your Save File to patch the resulting issue of the Shelf being bought, box Placed/Gone, but data not applied to say it's been Placed, to fix the issue you are facing, but also the ability to find why this happened and patch that part aswell so it doesn't happen to anyone else 🙂👍

Tiberius-Ryx-Tyr commented 3 months ago

Any way to manually give you my save?

Tiberius-Ryx-Tyr commented 3 months ago

The shelf reappears when I try to buy it again 20240328195244_1

FuryFight3r commented 3 months ago

There is still some old fix code on the Buy Object from an early v0.27ish update that changed the Ingot shelves, that should let you buy it again (at no cost) to reactivate it, though it's still incredibly strange that it's not being turned on when loading, especially more so that the game knows that you've not only bought the item, but also placed it.

As the Bought/Placed variables should be the only 2 variables that determine whether or not to activate the shelf when loading and seeing as yours definitely states it's Both Owned and Placed it 'should' check all the boxes to be enabled on startup 🤔🤔

You can manually send in your save file to my support email: admin@defectgaming.com If you are having issues with the in-game report feature, as this feature is only new as of the v0.37 update, yet I am still only getting the normal, discord/GitHub reports rather than the In-Game reports, so something may be wrong with that also, haven't had anyone besides myself test it at the moment, besides now yourself also as far as I know, so still got some kinks to work out with it I guess 😅

Tiberius-Ryx-Tyr commented 3 months ago

Are the Saves located in AppData not sure what files are the save or not, the .es3 file?

FuryFight3r commented 3 months ago

You should be able to click the 'Save File Directory' button on the Right hand side of the pause menu In-Game/On Main Menu to open the directory directly, however if that isn't working for you either (it's similar code to how the Generate Zip File button operates, so this may not work for you either) The directory is:

%AppData%/LocalLow/DefectGaming/Scrapping Simulator/

And the Save File will be named:

Scrapping_Simulator_Data.es3

The log files are also named:

Player.log
Player-prev.log
Tiberius-Ryx-Tyr commented 3 months ago

Ok thanks, Save Directory button works on the main menu at least

FuryFight3r commented 3 months ago

Hi again @Tiberius-Ryx-Tyr Thanks again for reporting this, I have just released a hotfix that will add a second check for the Ingot Shelf to make sure it's enabled If Purchased/Placed when loading, which should solve this issue for you :)