search

Fusion-Data-Platform / fdf

Obsolete FDF repo - see FDP repo for current development
MIT License
2 stars 0 forks source link

signals with different 'time' axes in the same container #36

Closed drsmith48 closed 8 years ago

drsmith48 commented 8 years ago

Some groups of signals, like filterscopes, have different time axes. It seems as if containers/signals/axes are designed for 1 time axis per container level. I think we need a mechanism to specify multiple time axes in a single container level. Maybe we need a mechanism to distinguish between axis name ('time') and axis label ('time_baye_haifa')? This way, baye_haifa and bayg_haifa can be signals with a 'time' attribute in the same container, but the time attributes point to different time axes. Thoughts?

ktritz commented 8 years ago

This already has been implemented. Not sure if one of the xml files shows how. There is a tag either axis_ref or something similar that specifies the name of the axis you want to use. On Nov 7, 2015 8:39 AM, "David R. Smith" notifications@github.com wrote:

Some groups of signals, like filterscopes, have different time axes. It seems as if containers/signals/axes are designed for 1 time axis per container level. I think we need a mechanism to specify multiple time axes in a single container level. Maybe we need a mechanism to distinguish between axis name ('time') and axis label ('time_baye_haifa')? This way, baye_haifa and bayg_haifa can be signals with a 'time' attribute in the same container, but the time attributes point to different time axes. Thoughts?

— Reply to this email directly or view it on GitHub https://github.com/Fusion-Data-Framework/fdf/issues/36.

ktritz commented 8 years ago

Looking at the code, I think the xml uses 'axis_refs' to refer to the name of the axis. So you would use it like this:

that way the signals te1 and te2 would both have a .time axis that would point to a different axis signal.
drsmith48 commented 8 years ago

Thanks, and a small correction for your example: 1) 'name' in axis element should match 'axes' in signal element 2) 'axis_refs' needs to be in both axis and signal elements For example:

    <axis name='time' axis_ref='time1' units='s' mdsnode='dim_of(\bayg_dalpha_eies)'></axis>
    <signal name='bayg_dalpha_eies' units='AU' axes='time' axis_ref='time1' mdsnode='\bayg_dalpha_eies' desc='midplane tangential'></signal>
hyyuh commented 8 years ago

This needs to make it into the XML doc. On Nov 10, 2015 6:35 PM, "David R. Smith" notifications@github.com wrote:

Closed #36 https://github.com/Fusion-Data-Framework/fdf/issues/36.

— Reply to this email directly or view it on GitHub https://github.com/Fusion-Data-Framework/fdf/issues/36#event-460743031.

ktritz commented 8 years ago

Hmm, I don't remember it being like that. I'll have to take a closer look at the code bc On Nov 10, 2015 6:35 PM, "David R. Smith" notifications@github.com wrote:

Thanks, and a small correction for your example: 1) 'name' in axis element should match 'axes' in signal element 2) 'axis_refs' needs to be in both axis and signal elements For example:

<axis name='time' axis_ref='time1' units='s' mdsnode='dim_of(\bayg_dalpha_eies)'></axis>
<signal name='bayg_dalpha_eies' units='AU' axes='time' axis_ref='time1' mdsnode='\bayg_dalpha_eies' desc='midplane tangential'></signal>

— Reply to this email directly or view it on GitHub https://github.com/Fusion-Data-Framework/fdf/issues/36#issuecomment-155602499 .