Fusion-Flux / Gravity-Api

A fabric mod and api that lets you change player gravity direction
Mozilla Public License 2.0
21 stars 19 forks source link

[INCOMPATIBILITY] Avoid function override #39

Closed charlyb01 closed 1 year ago

charlyb01 commented 2 years ago

Hello,

Somebody told me there was an incompatibility issue with my mod XP Storage. I checked both our codes and it seems the issue comes from your side. Indeed, I'm injecting in Minecraft code (modifying a variable actually) but you're overriding the associated function. Experience Bottles already override the use function so you shouldn't override it to avoid incompatibilities. Instead, you should try injections. I didn't really check why you override it, but it's sure you can do this. You could inject at head with cancel option for example, or if you can do better, do it because the first option is not really amazing. If you want me to check what else you could do, just tell me, I didn't take time yet.

Fusion-Flux commented 1 year ago

fixed