search

Fusion4Energy / F4Enix

API for parsing and post-processing many MC simulations related files
Other
12 stars 10 forks source link

Do not merge, PR to demo why we need src folder #70

Closed shimwell closed 6 months ago

shimwell commented 6 months ago

Description

To demonstrate why a src folder layout would be helpful I have removed files txt and excel from package files in the setup.cfg.

I notice the CI does a pip install . with the objective of testing the package

I think as we are in the repository root folder with a folder called f4enix in that same folder then when we run import f4enix we import that folder, not the package

So we are not testing what we think we are testing. We are testing the folder contents not the package

Moving to a src/f4enix layout would fix this

shimwell commented 6 months ago

Closing this as the purpose of the PR was to show that the CI passes even when we chop out the extra files from the setup.cfg. This shows we are testing the local f4enix folder and not the installed package. I've made a PR #71 to fix this with a src layout